In cases where property names cannot be parsed, log a warning instead of raising a KeyError #321
Conversation
… of raising a KeyError
extract_msg/named.py
Outdated
| streamID = properHex(0x8000 + entry['pid']) | ||
| self.__properties.append(StringNamedProperty(entry, names[entry['id']]) if entry['pkind'] == NamedPropertyType.STRING_NAMED else NumericalNamedProperty(entry)) | ||
| if entry['id'] in names: | ||
| streamID = properHex(0x8000 + entry['pid']) |
There was a problem hiding this comment.
Not directly related to the issue, but looks like this line could be removed since streamID is unused.
There was a problem hiding this comment.
Gonna take me a bit to look over the changes and what might have went wrong in the code to see what the best option is. Meanwhile, can you tell me how you did this thing that highlighted a section of code?
There was a problem hiding this comment.
@TheElementalOfDestruction Sounds good. I used this hex editor: https://hexfiend.com
There was a problem hiding this comment.
To be clear, I meant the highlighted section of code in the pull request I am responding to. Some kind of code suggestion?
There was a problem hiding this comment.
Also this suggestion is 100% the correct course. Pretty sure that was just something that got missed when I changed that section of code, so that line can just be deleted
There was a problem hiding this comment.
Oh right. I just added a comment by clicking the "+" on that line in the Files changed tab.
There was a problem hiding this comment.
Ah, thank you. Learned something new. Also sorry if you got a bunch of notifications, I was having a little trouble with using github
|
As for the if statement, it looks more like there is an error of some kind in the parsing which is critical and should not be suppressed. In the event it isn't my code (I'm checking my code to see if I can figure out what is happening), then I'll use this strategy |
next-releasebranch (orv0.29if applicable)?If you haven't completed the above items, please wait to create a PR until you have done so. We will try to review and reply to PRs as quickly as possible.
Once your PR is approved by a maintainer, we will either merge it into next-release or do a release with you or for you.
Thanks for contributing!