Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 명함생성뷰 생년월일 피커뷰에서 년도 삭제 #335

Closed
2 tasks done
hyun99999 opened this issue Jan 1, 2023 · 1 comment · Fixed by #337
Closed
2 tasks done

fix: 명함생성뷰 생년월일 피커뷰에서 년도 삭제 #335

hyun99999 opened this issue Jan 1, 2023 · 1 comment · Fixed by #337
Assignees
@hyun99999
Labels
Fix 코드 수정 및 버그, 오류 해결 Hyungyu 🐯 현규 교수님 작업

Comments

@hyun99999
Copy link
Member

hyun99999 commented Jan 1, 2023 •
edited
Loading

👀 이슈 (issue)

  • 나이를 노출하지 않기 위한 기획적 수정으로 인한 명함 생성뷰 피커뷰에서 년도 삭제

🚀 to-do

  • 피커뷰에서 년도를 제외
  • 그 과정에서 다음 이슈로 고려되는 피커뷰의 디자인적 구조 뜯어보기
@hyun99999 hyun99999 added Hyungyu 🐯 현규 교수님 작업 Fix 코드 수정 및 버그, 오류 해결 labels Jan 1, 2023
@hyun99999 hyun99999 self-assigned this Jan 1, 2023
@hyun99999
Copy link
Member Author

hyun99999 commented Jan 1, 2023 •
edited
Loading

서버에서 데이터 구조 변경되어 서버 api 제작 후 개발 시작 예정
바텀시트에 한해서 반영만 해두기로 결정

hyun99999 added a commit that referenced this issue Jan 3, 2023
@hyun99999
design: 생년월일 바텀시트의 이름 "날짜" 로 변경 (#335)
a817191
hyun99999 added a commit that referenced this issue Jan 3, 2023
@hyun99999
refactor: 피커뷰의 열 높이를 상수로 취급 (#335)
f11b374
hyun99999 added a commit that referenced this issue Jan 3, 2023
@hyun99999
refactor: Column 클래스를 사용하여 피커뷰의 행 구성 (#335)
412420c
hyun99999 added a commit that referenced this issue Jan 3, 2023
@hyun99999
fix: 년도 삭제 (#335)
8fd4039
@hyun99999 hyun99999 mentioned this issue Jan 3, 2023
Merged
hyun99999 added a commit that referenced this issue Jan 3, 2023
@hyun99999
Merge branch 'develop' of https://github.com/TeamNADA/NADA-iOS-ForRel…
e045eb4 
…ease into feature/#335
hyun99999 added a commit that referenced this issue Jan 3, 2023
@hyun99999
Merge pull request #337 from TeamNADA/feature/#335
464a699 
fix: 명함생성뷰 생년월일 피커뷰에서 년도 삭제 (#335)
@hyun99999 hyun99999 mentioned this issue Jan 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hyun99999 hyun99999

Labels
Fix 코드 수정 및 버그, 오류 해결 Hyungyu 🐯 현규 교수님 작업
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: 명함생성뷰 생년월일 피커뷰에서 년도 삭제 (#335) TeamNADA/NADA-iOS-ForRelease
1 participant
@hyun99999