[FEAT] #88 - 명함생성뷰에서 피커뷰로 생년월일, mbti 설정 #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Descriptions - 주석삭제 - FrontCardCreationViewCell 에 estimatedItemSize 를 zero 으로 설정(스보 설정 대신)
### Descriptions - Notification Center 을 활용해서 바텀시트에서 데이터 전달 - SelectBirthBottomViewController: 생년월일 커스텀 바텀시트 뷰 - SelectMBTIBottomViewController: MBTI 커스텀 바텀시트 뷰
dlwns33
approved these changes
Dec 1, 2021
Comment on lines
+219
to
+228
| if textField == birthTextField { | ||
| textField.endEditing(true) | ||
| presentingBirthBottomVCClosure?() | ||
| } else if textField == mbtiTextField { | ||
| textField.endEditing(true) | ||
| presentingMBTIBottomVCClosure?() | ||
| } else { | ||
| textField.borderWidth = 1 | ||
| textField.borderColor = .tertiary | ||
| } |
There was a problem hiding this comment.
default 에 대한 코드가 불필요하다고 느껴져서 저는 그렇게는 안쓰는거 같긴해여...
이번에 함 써보겠습니당
There was a problem hiding this comment.
아아아 그럴수도 있겠군요... 그러면 교수님 서타일대로 써주세용!!
There was a problem hiding this comment.
그래도 함 써볼게용! 통일해봅시당!
안해본것을 해보는것이 [도-약]
Comment on lines
+109
to
+130
| if component == 0 { | ||
| if pickerView.selectedRow(inComponent: component) == row { | ||
| label.attributedText = NSAttributedString(string: yearList[row], attributes: [NSAttributedString.Key.font: UIFont.textBold01, NSAttributedString.Key.foregroundColor: UIColor.mainColorNadaMain]) | ||
|
|
||
| } else { | ||
| label.attributedText = NSAttributedString(string: yearList[row], attributes: [NSAttributedString.Key.font: UIFont.textRegular03, NSAttributedString.Key.foregroundColor: UIColor.quaternary]) | ||
| } | ||
| } else if component == 1 { | ||
| if pickerView.selectedRow(inComponent: component) == row { | ||
| label.attributedText = NSAttributedString(string: monthList[row], attributes: [NSAttributedString.Key.font: UIFont.textBold01, NSAttributedString.Key.foregroundColor: UIColor.mainColorNadaMain]) | ||
|
|
||
| } else { | ||
| label.attributedText = NSAttributedString(string: monthList[row], attributes: [NSAttributedString.Key.font: UIFont.textRegular03, NSAttributedString.Key.foregroundColor: UIColor.quaternary]) | ||
| } | ||
| } else if component == 2 { | ||
| if pickerView.selectedRow(inComponent: component) == row { | ||
| label.attributedText = NSAttributedString(string: dayList[row], attributes: [NSAttributedString.Key.font: UIFont.textBold01, NSAttributedString.Key.foregroundColor: UIColor.mainColorNadaMain]) | ||
|
|
||
| } else { | ||
| label.attributedText = NSAttributedString(string: dayList[row], attributes: [NSAttributedString.Key.font: UIFont.textRegular03, NSAttributedString.Key.foregroundColor: UIColor.quaternary]) | ||
| } | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌴 PR 요약
🌱 작업한 브랜치
🌱 작업한 내용
📸 스크린샷
📮 관련 이슈