[FEAT] #111 - [FEAT] 온보딩 레이아웃 및 화면전환 구현 #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Descriptions - 온보딩 이미지 에셋 추가(온보딩, 버튼) - 온보딩 레이아웃 구현 - 로그인 뷰컨트롤러로 화면전환 구현
### Descriptions - UICollectionViewDelegate 에서 scrollViewWillEndDragging 메서드를 통해서 페이징 효과를 구현
### Descriptions - 코드 정리
…ease into feature/TeamNADA#111 # Conflicts: # NADA-iOS-forRelease/Sources/SceneDelegate.swift
|
현재 간격은 슬랙에서 얘기한대로 85고 나커톤때 라이브 코딩 쇼쇼쇼를 통해서.. 조절 예정입니다 |
dlwns33
approved these changes
Dec 7, 2021
Comment on lines
+17
to
+26
| private enum Size { | ||
| static let cellWidth: CGFloat = 327 | ||
| static let cellHeigth: CGFloat = 327 | ||
| static let cellTopInset: CGFloat = 198 | ||
| static let cellBottomInset: CGFloat = 208 | ||
| // TODO: - 나커톤 때 라이브코딩 쇼쇼쇼 | ||
| static let cellLineSpacing: CGFloat = 85 | ||
| // TODO: - 기기대응응 필요. | ||
| static let topSafeArea: CGFloat = 44 | ||
| } |
|
|
||
| // MARK: - Properties | ||
|
|
||
| var presentToLoginViewController: (() -> Void)? |
There was a problem hiding this comment.
클로저입니다! () -> () 이렇게로도 표현이 가능하지만 style share 코드 컨밴션을 따라서 위와 같이 표기했어요!!
야야 최이준 이거 세미나에 나왔다 야야 ㅋ ㅋ ㅋㅋㅋ ㅋ
mini-min
approved these changes
Dec 7, 2021
| // MARK: - @IBAction Properties | ||
|
|
||
| @IBAction func touchStartButton(_ sender: Any) { | ||
| presentToLoginViewController?() |
There was a problem hiding this comment.
셀안의 버튼을 누르면 뷰컨트롤러에서 화면전환하는 목적으로 구성했는데요! 셀에다가 클로저 옵셔널 변수를 만들고 셀을 뷰컨트롤러에서 만들어줄 때 delegate 에서 셀의 클로저 옵셔널 변수에 화면전환 코드를 넣는 로직입니당!
|
|
||
| private var currentIndex: CGFloat = 0 | ||
| private let onboardingList = ["onboarding01", "onboarding02", "onboarding03", "onboarding04"] | ||
| // TODO: - 🪓 선배륌들 이런 방법도있어서 써봤어여 사이즈같은 쓰이는 숫자들 여기서 다뤄도 좋을거 같아여.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌴 PR 요약
🌱 작업한 브랜치
🌱 작업한 내용
📸 스크린샷
📮 관련 이슈