Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] #116 - 명함생성 뷰 옵션 정보 수정시에도 delegate 작동 #122

Merged
merged 2 commits into from
Dec 9, 2021
Merged

[FIX] #116 - 명함생성 뷰 옵션 정보 수정시에도 delegate 작동 #122

merged 2 commits into from
Dec 9, 2021

Conversation

hyun99999
Copy link
Member

@hyun99999 hyun99999 commented Dec 8, 2021 •
edited
Loading

🌴 PR 요약

🌱 작업한 브랜치

🌱 작업한 내용

필수 정보만 수정시 넘겨주던 데이터를 필수, 옵션 정보를 수정시 넘겨주도록 함

  • 명함생성 뷰 옵션 정보 수정시에도 delegate 작동
  • FrontCardCreationCollectionViewCell : 텍스트 필드 end 될 때 호출해서 데이터를 일괄 전송
  • BackCardCreationCollectionViewCell : 텍스트 필드 end 될 때, 취향 컬렉션뷰 눌릴 때 호출해서 데이터를 일괄 전송

📮 관련 이슈

@hyun99999
[FIX] TeamNADA#116 - 명함생성 뷰 옵션 정보 수정시에도 delegate 작동
435379d 
- 명함생성 뷰 옵션 정보 수정시에도 delegate 작동
- FrontCardCreationCollectionViewCell : 텍스트 필드 end 될 때 호출해서 데이터를 일괄 전송
- BackCardCreationCollectionViewCell : 텍스트 필드 end 될 때, 취향 컬렉션뷰 눌릴 때 호출해서 데이터를 일괄 전송
@hyun99999 hyun99999 added Hyungyu 🐯 현규 교수님 작업 Fix 코드 수정 및 버그, 오류 해결 labels Dec 8, 2021
@hyun99999 hyun99999 self-assigned this Dec 8, 2021
@mini-min mini-min self-requested a review December 9, 2021 05:59
mini-min
mini-min approved these changes Dec 9, 2021
View reviewed changes
Copy link
Member

@mini-min mini-min left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다ㅜㅜ
저도 로그인빨리 해야하는데....컨플릭트만 잡아서 머지해주세요 교수님!!

dlwns33
dlwns33 approved these changes Dec 9, 2021
View reviewed changes
Copy link
Member

@dlwns33 dlwns33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다 교수니이임!

@hyun99999
Copy link
Member Author

앞선 풀리퀘가 머지되서 충돌났나보당 해결하구 머지할게요~

@hyun99999 hyun99999 merged commit 85a1c50 into TeamNADA:develop Dec 9, 2021
@hyun99999 hyun99999 deleted the feature/#116 branch December 9, 2021 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlwns33 dlwns33 dlwns33 approved these changes

@mini-min mini-min mini-min approved these changes

Assignees

@hyun99999 hyun99999

Labels
Fix 코드 수정 및 버그, 오류 해결 Hyungyu 🐯 현규 교수님 작업
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FIX] 명함생성 뷰 옵션 정보 수정시에도 delegate 작동
3 participants
@hyun99999 @dlwns33 @mini-min