[FIX] #124 - 온보딩 카드 간격, 바운스 수정 #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 주석 삭제 - qa 를 거쳐서 확정
hyun99999
added
Hyungyu 🐯
dlwns33
approved these changes
Dec 10, 2021
Comment on lines
25
to
-26
| window?.rootViewController = UIStoryboard(name: Const.Storyboard.Name.tabBar, bundle: nil).instantiateViewController(withIdentifier: Const.ViewController.Identifier.tabBarViewController) | ||
| // window?.rootViewController = UIStoryboard(name: Const.Storyboard.Name.login, bundle: nil).instantiateViewController(withIdentifier: Const.ViewController.Identifier.loginViewController) |
Comment on lines
16
to
22
| private enum Size { | ||
| static let cellWidth: CGFloat = 327 | ||
| static let cellHeigth: CGFloat = 327 | ||
| static let cellTopInset: CGFloat = 198 | ||
| static let cellBottomInset: CGFloat = 208 | ||
| // TODO: - 나커톤 때 라이브코딩 쇼쇼쇼 | ||
| static let cellLineSpacing: CGFloat = 85 | ||
| // TODO: - 기기대응응 필요. | ||
| static let topSafeArea: CGFloat = 44 |
There was a problem hiding this comment.
사이즈 사이즈 사이즈~ 사이즈~ 사이즈 조정~ 이거 저번에 했던 그 방식에서 숫자만 변경된건가요!!! !!! !! !! ! ! !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌴 PR 요약
🌱 작업한 브랜치
🌱 작업한 내용
📸 스크린샷
📮 관련 이슈