[FEAT] #118 - FrontCardCell 에서 인스타 앱, 링크 사파리 연결 #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 인스타 앱, 사파리 링크 연결 - 인스타 없을 시 사파리로 연결
dlwns33
approved these changes
Dec 10, 2021
Comment on lines
-58
to
-59
| // TODO: - 2차 릴리즈/공유기능 | ||
| shareButton.isHidden = true |
Comment on lines
+80
to
+85
| if UIApplication.shared.canOpenURL(appURL) { | ||
| UIApplication.shared.open(appURL, options: [:], completionHandler: nil) | ||
| } else { | ||
| UIApplication.shared.open(webURL, options: [:], completionHandler: nil) | ||
| } | ||
| } |
Comment on lines
164
to
167
| extension FrontViewController: VerticalCardSwiperDelegate { | ||
| // TODO: - FrontCard 에서 링크를 통한 인스타, 사파리 접속을 위해 주석 처리. | ||
| func didTapCard(verticalCardSwiperView: VerticalCardSwiperView, index: Int) { | ||
| let frontCell = cardSwiper.cardForItem(at: index) |
mini-min
approved these changes
Dec 10, 2021
Comment on lines
-58
to
-59
| // TODO: - 2차 릴리즈/공유기능 | ||
| shareButton.isHidden = true |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌴 PR 요약
🌱 작업한 브랜치
🌱 작업한 내용
📮 관련 이슈