Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] #114 - 스플래시 뷰 구현, 탭바 수정 자잘한 작업 진행 #129

Merged
merged 6 commits into from
Dec 10, 2021
Merged

[FEAT] #114 - 스플래시 뷰 구현, 탭바 수정 자잘한 작업 진행 #129

merged 6 commits into from
Dec 10, 2021

Conversation

mini-min
Copy link
Member

@mini-min mini-min commented Dec 10, 2021 •
edited
Loading

🌴 PR 요약

🌱 작업한 브랜치

🌱 작업한 내용

  • 스플래시 뷰 제작 -> 연결은 아직 안해뒀습니다 just 등록만! + 다크모드 대응까지
  • 스플래시 뷰컨, 스보 모두 Const 등록
  • 탭바 구분선만 추가

📸 스크린샷

기능 스크린샷 기능 스크린샷
스플래시 스크린샷 2021-12-10 오후 5 35 59 탭바 구분선 simulator_screenshot_4B0C06F0-0F4B-43D4-92EE-BA17BA466C3B

📮 관련 이슈

@mini-min mini-min added Minjae 🐻‍❄️ 민재 강남1타강사 작업 P1 / Priority High 우선순위 높음 Feat 새로운 기능 구현 labels Dec 10, 2021
@mini-min mini-min self-assigned this Dec 10, 2021
hyun99999
hyun99999 approved these changes Dec 10, 2021
View reviewed changes
Copy link
Member

@hyun99999 hyun99999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

스플래시도 다크모드 추가하면 될거 같아요!

@mini-min mini-min merged commit 424a7f1 into TeamNADA:develop Dec 10, 2021
@mini-min mini-min deleted the feature/#114 branch December 10, 2021 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyun99999 hyun99999 hyun99999 approved these changes

@dlwns33 dlwns33 Awaiting requested review from dlwns33

Assignees

@mini-min mini-min

Labels
Feat 새로운 기능 구현 Minjae 🐻‍❄️ 민재 강남1타강사 작업 P1 / Priority High 우선순위 높음
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEAT] 스플래시 뷰 구현, 탭바 수정 자잘한 작업 진행
2 participants
@mini-min @hyun99999