Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] #128 - mbti, 생년월일 바텀시트 dismiss 수정 및 명함 배경 추가 #132

Merged
merged 3 commits into from
Dec 10, 2021

Conversation

hyun99999
Copy link
Member

@hyun99999 hyun99999 commented Dec 10, 2021

🌴 PR 요약

🌱 작업한 브랜치

🌱 작업한 내용

  • 기본 명함 배경 에셋 추가
  • 커먼바텀시트 dismiss 메서드 사용

뷰 레이아웃 수정

  • 명함생성 뷰 명함 배경 추가
  • 명함 배경 선택 테두리 색 변경(메인나다색으로)
  •  카드 불투명도 0.4->0.2변경
  • 명함 기본배경 설정

추가

  • 피커뷰 코드 정리(조건문 수정)

📸 스크린샷

기능 스크린샷
GIF

📮 관련 이슈

- 커먼바텀시트 dismiss 메서드 사용
- 명함생성 뷰 명함 배경 추가
- 피커뷰 코드 정리(조건문 수정)
- 명함 배경 선택 테두리 색 변경(메인나다색으로)
-  카드 불투명도 0.4->0.2변경
- 명함 기본배경 설정
@hyun99999 hyun99999 added Hyungyu 🐯 현규 교수님 작업 P1 / Priority High 우선순위 높음 Feat 새로운 기능 구현 labels Dec 10, 2021
@hyun99999 hyun99999 self-assigned this Dec 10, 2021
Copy link
Member

@dlwns33 dlwns33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

싸장님 나이스샷~

@@ -15,7 +15,7 @@ class FrontCardCreationCollectionViewCell: UICollectionViewCell {

// MARK: - Properties

private let backgroundList = ["img", "img", "img", "img", "img"]
private let backgroundList = ["", "imageDefaultBg01", "imageDefaultBg02", "imageDefaultBg03", "imageDefaultBg04", "imageDefaultBg05", "imageDefaultBg06", "imageDefaultBg07"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이미지 들어와썽!!!!!

@@ -81,7 +81,7 @@ extension SelectBirthBottomSheetViewController {

@objc func dismissToCardCreationViewController() {
NotificationCenter.default.post(name: .frontCardBirth, object: selectedBirth)
dismiss(animated: true, completion: nil)
hideBottomSheetAndGoBack()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

싸장님 나이스샷

@hyun99999 hyun99999 merged commit 79af30e into TeamNADA:develop Dec 10, 2021
@hyun99999 hyun99999 deleted the feature/#128 branch December 10, 2021 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feat 새로운 기능 구현 Hyungyu 🐯 현규 교수님 작업 P1 / Priority High 우선순위 높음
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] mbti, 생년월일 바텀시트 dismiss 수정 및 명함 배경 추가
2 participants