Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] #133 - 메인에서 카드셀 좌우 스와이프로 바꾸기 구현 #138

Merged
merged 1 commit into from
Dec 10, 2021

Conversation

hyun99999
Copy link
Member

@hyun99999 hyun99999 commented Dec 10, 2021

  • 메인에서 카드셀 좌우 스와이프

🌴 PR 요약

🌱 작업한 브랜치

🌱 작업한 내용

  • 초반에 작게 표현된건 MainCardCell xib 의 frame 을 작게 설정해서 그랬다 -> 327*540 으로 설정

UICollectionView 의 사이즈를 설정하는 그런 flowlayout 역할이 없었기 때문에.

  • 카드 사이즈 설정 = 높이는 topinset 과 cardspacing 과 visible next card height 를, 너비는 side inset을 포함한 크기

거기까지 고려해서 return CGSize(width: 375, height: 630) 이렇게 설정

📸 스크린샷

기능 스크린샷
GIF

📮 관련 이슈

@hyun99999 hyun99999 added Hyungyu 🐯 현규 교수님 작업 P1 / Priority High 우선순위 높음 Fix 코드 수정 및 버그, 오류 해결 labels Dec 10, 2021
@hyun99999 hyun99999 self-assigned this Dec 10, 2021
Copy link
Member

@dlwns33 dlwns33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

진짜 교수님 이거 했으니까 다했네? 자네 승진이야!

Copy link
Member

@mini-min mini-min left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

진짜 고생하셨습니다 교수님 ㅠㅜㅠㅜㅠ

Comment on lines -11 to -12
static let deleteTabBar = NSNotification.Name("deleteTabBar")
static let expressTabBar = NSNotification.Name("expressTabBar")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

미처 지우지 못한거 죄송합니다 ㅠㅠ

Comment on lines +65 to +66
public func initCell(cardDataModel: Card) {
self.cardDataModel = cardDataModel
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

감싸합니ㄷㅏ👍🏻

Comment on lines +12 to +16
<collectionViewCell opaque="NO" clipsSubviews="YES" multipleTouchEnabled="YES" contentMode="center" restorationIdentifier="MainCardCell" id="gTV-IL-0wX" customClass="MainCardCell" customModule="NADA_iOS_forRelease" customModuleProvider="target">
<rect key="frame" x="0.0" y="0.0" width="327" height="540"/>
<autoresizingMask key="autoresizingMask"/>
<view key="contentView" opaque="NO" clipsSubviews="YES" multipleTouchEnabled="YES" contentMode="center">
<rect key="frame" x="0.0" y="0.0" width="219" height="219"/>
<rect key="frame" x="0.0" y="0.0" width="327" height="540"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고뇌의 흔적이군요 ^__^

Comment on lines +135 to +136
func sizeForItem(verticalCardSwiperView: VerticalCardSwiperView, index: Int) -> CGSize {
return CGSize(width: 375, height: 630)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@hyun99999 hyun99999 merged commit 0dc681b into TeamNADA:develop Dec 10, 2021
@hyun99999 hyun99999 deleted the feature/#133 branch December 10, 2021 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix 코드 수정 및 버그, 오류 해결 Hyungyu 🐯 현규 교수님 작업 P1 / Priority High 우선순위 높음
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FIX] 메인에서 카드셀 좌우 스와이프로 바꾸기 구현
3 participants