-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] #142 - 그룹명 변경 기능 구현 #143
Conversation
- cyclomatic_complexity | ||
- file_length |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
추가할 때 다같이 한번 이야기해봐요!
저번에 제가 swift lint 같이 쓰던 팀원은 저보다 경험이 좀 더 많은데 최대한 추가하지 않으려고 하더라구요 분명 cyclomatic_complexity 도 클린코딩을 추구하면서 리펙하면 워닝을해결할 수 있을거에요..!!
file_length 는 400줄 워닝일텐데 아마 서버 로직 옮기면 400을 넘기지는 않을거에요..! 일단 여기에 추가하고 나중에 swift lint 도 만져봅시다..!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
넵넵 알겠습니다!!
}, completion: { _ in | ||
if self.presentingViewController != nil { | ||
self.dismiss(animated: false, completion: nil) | ||
} | ||
} | ||
}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이것도 워닝 해결이죵? 굳입니다!
import UIKit | ||
import IQKeyboardManagerSwift | ||
|
||
class GroupNameEditBottomSheetViewController: CommonBottomSheetViewController, UITextFieldDelegate { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
슬랙봤어여! 기디결정에 따라서 수정할수도 있을텐데 화이팅입니다!
nextVC.modalPresentationStyle = .overFullScreen | ||
nextVC.text = cardItems[index!.row] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
강제추출은 지양하는것이 좋을거 같아요!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
맞네욥!!! 좋은 피드백 감사합니당 ^__^
🌴 PR 요약
🌱 작업한 브랜치
🌱 작업한 내용
📸 스크린샷
📮 관련 이슈