[FEAT] #142 - 그룹명 변경 기능 구현 #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mini-min
added
Minjae 🐻❄️
hyun99999
approved these changes
Dec 13, 2021
Comment on lines
+7
to
+8
| - cyclomatic_complexity | ||
| - file_length |
There was a problem hiding this comment.
추가할 때 다같이 한번 이야기해봐요!
저번에 제가 swift lint 같이 쓰던 팀원은 저보다 경험이 좀 더 많은데 최대한 추가하지 않으려고 하더라구요 분명 cyclomatic_complexity 도 클린코딩을 추구하면서 리펙하면 워닝을해결할 수 있을거에요..!!
file_length 는 400줄 워닝일텐데 아마 서버 로직 옮기면 400을 넘기지는 않을거에요..! 일단 여기에 추가하고 나중에 swift lint 도 만져봅시다..!
Comment on lines
+189
to
+193
| }, completion: { _ in | ||
| if self.presentingViewController != nil { | ||
| self.dismiss(animated: false, completion: nil) | ||
| } | ||
| } | ||
| }) |
| import UIKit | ||
| import IQKeyboardManagerSwift | ||
|
|
||
| class GroupNameEditBottomSheetViewController: CommonBottomSheetViewController, UITextFieldDelegate { |
There was a problem hiding this comment.
슬랙봤어여! 기디결정에 따라서 수정할수도 있을텐데 화이팅입니다!
| nextVC.modalPresentationStyle = .overFullScreen | ||
| nextVC.text = cardItems[index!.row] |
There was a problem hiding this comment.
맞네욥!!! 좋은 피드백 감사합니당 ^__^
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌴 PR 요약
🌱 작업한 브랜치
🌱 작업한 내용
📸 스크린샷
📮 관련 이슈