[FIX] #158 - 명함생성뷰 이미지피커 dismiss 동작 추가 #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 이미지피커 cancel 할 때 dismiss 추가 - 이미지피커 cancel 하면 셀 디셀렉트 하기 - 앱시작부분 탭바로 변경
- 명함배경을 마지막으로 선택하면 필수정보체크하지 않던 버그픽스 - 명함배경선택시 imagepicker 를 fullscreen 으로 띄워서 pagesheet 인 경우 취소를 누를때 통제가 되지만 창을 드래그해서 내릴때는 아무런 통제를 할 수 없는 부분을 해결 - imagepicker 선택 후 아무것도 선택하지 않으면 셀 디셀렉트 구현 - 커스텀 배경을 사용할 경우(defaultImageIndex 변수가 0이 될 경우)는 imagepicker 에서 사진 고른 후 / 사진 고른 후 다른 기본명함 선택했다가 다시 imagepicker 띄웠지만 취소 누른경우 - 미리보기 뷰에서는 guard let 구문 추가
hyun99999
added
Hyungyu 🐯
dlwns33
approved these changes
Dec 16, 2021
Comment on lines
+25
to
+26
| window?.rootViewController = UIStoryboard(name: Const.Storyboard.Name.tabBar, bundle: nil).instantiateViewController(withIdentifier: Const.ViewController.Identifier.tabBarViewController) | ||
| // window?.rootViewController = UIStoryboard(name: Const.Storyboard.Name.splash, bundle: nil).instantiateViewController(withIdentifier: Const.ViewController.Identifier.splashViewController) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌴 PR 요약
🌱 작업한 브랜치
🌱 작업한 내용
이미지 피커
버그 픽스
기디의 QA? 무섭지않아
📮 관련 이슈