Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] #176 - 명함 앞면 뷰 URL 앞에 https:// 체크 #181

Merged
merged 1 commit into from
Dec 21, 2021
Merged

[FIX] #176 - 명함 앞면 뷰 URL 앞에 https:// 체크 #181

merged 1 commit into from
Dec 21, 2021

Conversation

hyun99999
Copy link
Member

🌴 PR 요약

🌱 작업한 브랜치

🌱 작업한 내용

  • prefix 확인 후 https:// 추가

📸 스크린샷

기능 스크린샷
주소입력
네이버접속

📮 관련 이슈

@hyun99999
[FIX] #176 - 명함 앞면 뷰 URL 앞에 https:// 체크
2977644 
- prefix 확인 후 https:// 추가
@hyun99999 hyun99999 added Hyungyu 🐯 현규 교수님 작업 Fix 코드 수정 및 버그, 오류 해결 QA QA 과정 중 나오는 이슈 labels Dec 21, 2021
@hyun99999 hyun99999 self-assigned this Dec 21, 2021
mini-min
mini-min approved these changes Dec 21, 2021
View reviewed changes
NADA-iOS-forRelease/Sources/Cells/CardCell/FrontCardCell.swift
let webURL = URL(string: linkURL)!
let webURL: URL

if linkURL.hasPrefix("https://") {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오 이런것도 있군요!! 배우고 갑니다 교수님!

dlwns33
dlwns33 approved these changes Dec 21, 2021
View reviewed changes
Copy link
Member

@dlwns33 dlwns33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

룩스굿투미!

@hyun99999 hyun99999 merged commit 540818b into release1.0/1 Dec 21, 2021
@hyun99999 hyun99999 deleted the release1.0/#176 branch December 21, 2021 05:57
@hyun99999 hyun99999 mentioned this pull request Dec 25, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlwns33 dlwns33 dlwns33 approved these changes

@mini-min mini-min mini-min approved these changes

Assignees

@hyun99999 hyun99999

Labels
Fix 코드 수정 및 버그, 오류 해결 Hyungyu 🐯 현규 교수님 작업 QA QA 과정 중 나오는 이슈
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FIX] 명함 앞면 뷰 URL 앞에 https:// 체크
3 participants
@hyun99999 @dlwns33 @mini-min