Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] #178 - 명함생성 미리보기 뷰 뒷면 공유하기 버튼 히든 #182

Merged
merged 3 commits into from
Dec 21, 2021
Merged

[FIX] #178 - 명함생성 미리보기 뷰 뒷면 공유하기 버튼 히든 #182

merged 3 commits into from
Dec 21, 2021

Conversation

hyun99999
Copy link
Member

🌴 PR 요약

🌱 작업한 브랜치

🌱 작업한 내용

  • 필수가 아닌 self 제거
  • 공유하기 때 사용하는 initCell() 메서드 변경
  • 공유하기 버튼 히든

📸 스크린샷

기능 스크린샷
공유하기 히든

📮 관련 이슈

@hyun99999
[FIX] #178 - 명함생성 미리보기 뷰 뒷면 공유하기 버튼 히든
ec5135f 
- 필수가 아닌 self 제거
- 공유하기 때 사용하는 initCell() 메서드 변경
- 공유하기 버튼 히든
@hyun99999
[FIX] #178 - 명함생성 미리보기 뷰 뒷면 공유하기 버튼 히든
cfc2f38 
- 공유하기 버튼 히든
@hyun99999
[FIX] #178 - 명함생성 미리보기 뷰 뒷면 공유하기 버튼 히든
663ebb1 
- 공유하기 버튼 히든
@hyun99999 hyun99999 added Hyungyu 🐯 현규 교수님 작업 Fix 코드 수정 및 버그, 오류 해결 QA QA 과정 중 나오는 이슈 labels Dec 21, 2021
@hyun99999 hyun99999 self-assigned this Dec 21, 2021
mini-min
mini-min approved these changes Dec 21, 2021
View reviewed changes
Copy link
Member

@mini-min mini-min left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

하나씩 쌓여가는 QA목록들....👍🏻

dlwns33
dlwns33 approved these changes Dec 21, 2021
View reviewed changes
Copy link
Member

@dlwns33 dlwns33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

큐에이 딱대~

NADA-iOS-forRelease/Sources/Cells/CardCell/BackCardCell.swift
secondTmiLabel.text = secondTMI
thirdTmiLabel.text = thirdTMI

shareButton.isHidden = !isShareable
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿굿!

@hyun99999 hyun99999 merged commit 663ebb1 into release1.0/1 Dec 21, 2021
@hyun99999 hyun99999 deleted the release1.0/#178 branch December 24, 2021 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlwns33 dlwns33 dlwns33 approved these changes

@mini-min mini-min mini-min approved these changes

Assignees

@hyun99999 hyun99999

Labels
Fix 코드 수정 및 버그, 오류 해결 Hyungyu 🐯 현규 교수님 작업 QA QA 과정 중 나오는 이슈
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FIX] 명함생성 미리보기 뷰 뒷면 공유하기 버튼 히든
3 participants
@hyun99999 @dlwns33 @mini-min