Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] #168 - 공유하기 뷰 구현 #186

Merged
merged 8 commits into from
Dec 21, 2021

Conversation

dlwns33
Copy link
Member

@dlwns33 dlwns33 commented Dec 21, 2021

🌴 PR 요약

🌱 작업한 브랜치

🌱 작업한 내용

  • 공유하기 뷰가 완료되었습니다
  • 이미지로 저장하는것은 아직 안된상태에요! 서버 붙인 뒤 이슈 따로 파서 작업하겠습니다!
  • 공유 버튼 누르면 노티피케이션 추가했습니다!
  • 아이디 복사, 갤러리에 이미지로 저장하면 토스트 메시지 추가했습니다!

📸 스크린샷

기능 스크린샷 기능 스크린샷
전체화면 Simulator Screen Shot - iPhone 11 - 2021-12-21 at 17 52 02 GIF ezgif com-gif-maker (6)

📮 관련 이슈

@dlwns33 dlwns33 added Yijoon 🐨 이준 대치동강사 작업 Feat 새로운 기능 구현 Design just 화면 labels Dec 21, 2021
@dlwns33 dlwns33 self-assigned this Dec 21, 2021
Copy link
Member

@mini-min mini-min left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다 선배님👍🏻

@@ -33,6 +33,7 @@ class BackCardCell: CardCell {
setUI()
}
@IBAction func touchShareButton(_ sender: Any) {
NotificationCenter.default.post(name: NSNotification.Name("presentCardShare"), object: nil, userInfo: nil)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 Notification도 Const에 추가해서 사용하면 좋을것 같습니다!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오앗 알겠숨다!!

@@ -30,6 +30,7 @@ class FrontCardCell: CardCell {
setTapGesture()
}
@IBAction func touchShareButton(_ sender: Any) {
NotificationCenter.default.post(name: NSNotification.Name("presentCardShare"), object: nil, userInfo: nil)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기두요!

Comment on lines +71 to +86
case "QRScan":
toastLabel = UILabel(frame: CGRect(x: self.view.frame.size.width/2 - 85,
y: self.view.frame.size.height - 230,
width: 170, height: 35))
case "copyID":
toastLabel = UILabel(frame: CGRect(x: self.view.frame.size.width/2 - 100,
y: self.view.frame.size.height/2,
width: 200, height: 35))
case "saveImage":
toastLabel = UILabel(frame: CGRect(x: self.view.frame.size.width/2 - 85,
y: self.view.frame.size.height/2,
width: 170, height: 35))
default:
toastLabel = UILabel(frame: CGRect(x: self.view.frame.size.width/2 - 85,
y: self.view.frame.size.height - 230,
width: 170, height: 35))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@dlwns33 dlwns33 merged commit 9837f7d into TeamNADA:release1.0/1 Dec 21, 2021
@dlwns33 dlwns33 deleted the release/#168 branch December 21, 2021 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Design just 화면 Feat 새로운 기능 구현 Yijoon 🐨 이준 대치동강사 작업
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] 공유하기 뷰
2 participants