Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] #140 - 명함 그룹 뷰 서버연결 #188

Merged
merged 6 commits into from
Dec 21, 2021

Conversation

dlwns33
Copy link
Member

@dlwns33 dlwns33 commented Dec 21, 2021

🌴 PR 요약

🌱 작업한 브랜치

🌱 작업한 내용

  • 그룹뷰에 서버가 참 많네요. 그러므로 한번 이슈 닫고 세부적으로 다시 파서 진행하겠습니다.
  • 그룹 리스트 조회 서버 연결
  • 그룹 안에 카드 조회 서버연결
  • 명함 상세 보기 서버 연결
  • 나중에 더미가 더 많이 생기면 그때 테스트 해보겠습니다!
  • 지금 userId 다 정적으로 되있는 것들은 나중에 다 UserDefaults에 있는 const로 바꾸도록 하겠습니다!

📸 스크린샷

기능 스크린샷 기능 스크린샷
명함그룹뷰 Simulator Screen Shot - iPhone 11 - 2021-12-21 at 21 03 04 명함상세뷰 Simulator Screen Shot - iPhone 11 - 2021-12-21 at 21 03 11
GIF ezgif com-gif-maker (7)

📮 관련 이슈

@dlwns33 dlwns33 added Yijoon 🐨 이준 대치동강사 작업 Feat 새로운 기능 구현 labels Dec 21, 2021
@dlwns33 dlwns33 self-assigned this Dec 21, 2021
Copy link
Member

@mini-min mini-min left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

머지해주시면 바뀐거 맞춰서 서버 붙일게요! 고생하셨습니다 ^__^

Comment on lines +10 to +14
// MARK: - DataClass
struct CardClass: Codable {
let card: Card
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

화긴했습니다 감사합니다!

Comment on lines +208 to +223
nextVC.cardDataModel = Card(cardID: card.card.cardID,
background: card.card.background,
title: card.card.title,
name: card.card.name,
birthDate: card.card.birthDate,
mbti: card.card.mbti,
instagram: card.card.instagram,
link: card.card.link,
cardDescription: card.card.cardDescription,
isMincho: card.card.isMincho,
isSoju: card.card.isSoju,
isBoomuk: card.card.isBoomuk,
isSauced: card.card.isSauced,
oneTmi: card.card.oneTmi,
twoTmi: card.card.twoTmi,
threeTmi: card.card.threeTmi)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

card.card 뭔가 웃기네요 ㅎㅅㅎ

@dlwns33 dlwns33 merged commit b50f067 into TeamNADA:release1.0/1 Dec 21, 2021
@dlwns33 dlwns33 deleted the release/#140 branch December 21, 2021 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feat 새로운 기능 구현 Yijoon 🐨 이준 대치동강사 작업
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] 명함 그룹 뷰 서버
2 participants