Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] #195 - 명함생성 userId 추가 및 미리보기 행간 추가 #197

Merged
merged 3 commits into from
Dec 22, 2021

Conversation

hyun99999
Copy link
Member

🌴 PR 요약

🌱 작업한 브랜치

🌱 작업한 내용

  • 명함생성 userId 추가
  • 미리보기 뷰 안내문구 행간 추가

간격을 몰라서 슬랙에 물어본 상황 답변 받고 추가할게욥!

📮 관련 이슈

@hyun99999 hyun99999 added the Fix 코드 수정 및 버그, 오류 해결 label Dec 21, 2021
@hyun99999 hyun99999 self-assigned this Dec 21, 2021
Copy link
Member

@mini-min mini-min left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

어우 어제 해두신건가요,,,? 주무시라니깐.....ㅎ
고생하셨습니다 ^___^

Comment on lines 61 to 67

// TODO: - 행간 설정
// let attributeString = NSMutableAttributedString(string: noticeLabel?.text ?? "")
// let paragraphStyle = NSMutableParagraphStyle()
// paragraphStyle.lineSpacing = 19
// attributeString.addAttribute(NSAttributedString.Key.paragraphStyle, value: paragraphStyle, range: NSRange(location: 0, length: attributeString.length))
// noticeLabel.attributedText = attributeString
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

화이팅입니다 ^___^

- 행간 추가
- 글머리 기호 변경(저번 이슈에서 수정하지 못한 부분)
Copy link
Member

@dlwns33 dlwns33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨어용!

@hyun99999 hyun99999 merged commit 90c70d5 into release1.0/1 Dec 22, 2021
@hyun99999 hyun99999 deleted the release1.0/#195 branch December 22, 2021 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix 코드 수정 및 버그, 오류 해결
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FIX] 명함생성 userId 추가 및 미리보기 행간 추가
3 participants