Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] #198 - 첫 명함생성 시 바텀시트 구현 #206

Merged
merged 4 commits into from
Dec 23, 2021
Merged

[FEAT] #198 - 첫 명함생성 시 바텀시트 구현 #206

merged 4 commits into from
Dec 23, 2021

Conversation

hyun99999
Copy link
Member

@hyun99999 hyun99999 commented Dec 23, 2021 •
edited
Loading

🌴 PR 요약

🌱 작업한 브랜치

🌱 작업한 내용

  • fixme qa 테플용으로 현재 viewWillAppear 로 테스트
  • 추후 로직 변경예정

📮 관련 이슈

@hyun99999 hyun99999 added Hyungyu 🐯 현규 교수님 작업 Fix 코드 수정 및 버그, 오류 해결 labels Dec 23, 2021
@hyun99999 hyun99999 self-assigned this Dec 23, 2021
dlwns33
dlwns33 approved these changes Dec 23, 2021
View reviewed changes
Copy link
Member

@dlwns33 dlwns33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

으아아아아아악 으아아아악!!!

@hyun99999 hyun99999 merged commit ecc079c into release1.0/1 Dec 23, 2021
@hyun99999 hyun99999 deleted the release1.0/#198 branch December 23, 2021 12:00
@hyun99999 hyun99999 mentioned this pull request Dec 25, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlwns33 dlwns33 dlwns33 approved these changes

@mini-min mini-min mini-min approved these changes

Assignees

@hyun99999 hyun99999

Labels
Fix 코드 수정 및 버그, 오류 해결 Hyungyu 🐯 현규 교수님 작업
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEAT] 첫 명함생성 시 바텀시트 구현
3 participants
@hyun99999 @dlwns33 @mini-min