Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#20] - 명함 리스트뷰 Alert창 구현 & 연결 #21

Merged
merged 2 commits into from
Oct 2, 2021
Merged

[#20] - 명함 리스트뷰 Alert창 구현 & 연결 #21

merged 2 commits into from
Oct 2, 2021

Conversation

mini-min
Copy link
Member

@mini-min mini-min commented Oct 1, 2021

🌴 PR 요약

🌱 작업한 브랜치

🌱 작업한 내용

  • Alert 함수 추가
  • 커스텀 디자인을 위한 Extension 추가
  • Swipe Action과 연결

📸 스크린샷

기능 스크린샷
GIF Simulator Screen Recording - iPhone 12 mini - 2021-10-01 at 15 49 10

📮 관련 이슈

@mini-min mini-min added Minjae 🐻‍❄️ 민재 강남1타강사 작업 P1 / Priority High 우선순위 높음 Feat 새로운 기능 구현 labels Oct 1, 2021
@mini-min mini-min self-assigned this Oct 1, 2021
Copy link
Member

@hyun99999 hyun99999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

그룹삭제 할 때도 alert 창이 사용되는데 삭제 목적으로 한 alert 창 만드는 코드를 extension 으로 빼는건 어떨까요?

extension UIAlertController {

// Set title font and title color
func setTitlet(font: UIFont?, color: UIColor?) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

함수명을 setTitlet 으로 정한 이유가 있나여..?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

setTitle이 하나 잘못 눌렀습니당 수정할게요 !!

@mini-min
Copy link
Member Author

mini-min commented Oct 1, 2021

그룹삭제 할 때도 alert 창이 사용되는데 삭제 목적으로 한 alert 창 만드는 코드를 extension 으로 빼는건 어떨까요?

아 그렇게 할까용??

@mini-min mini-min merged commit 97332a0 into TeamNADA:develop Oct 2, 2021
@mini-min mini-min deleted the feature/#20 branch October 2, 2021 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feat 새로운 기능 구현 Minjae 🐻‍❄️ 민재 강남1타강사 작업 P1 / Priority High 우선순위 높음
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] 명함 리스트뷰 Alert창 구현
2 participants