Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] #219 - 명함 그룹 수정 서버 #220

Merged
merged 5 commits into from
Dec 25, 2021

Conversation

dlwns33
Copy link
Member

@dlwns33 dlwns33 commented Dec 25, 2021

🌴 PR 요약

🌱 작업한 브랜치

🌱 작업한 내용

  • 명함 수정 서버를 붙였습니다
  • 그룹 뷰로 돌아올때마다 미분류로 초기화 되는 문제가 있어서 selectedRow라는 변수를 추가하고 저장했습니다.

📸 스크린샷

기능 스크린샷 기능 스크린샷
전체화면 Simulator Screen Shot - iPhone 12 mini - 2021-12-25 at 16 42 50 GIF ezgif com-gif-maker (9)

📮 관련 이슈

@dlwns33 dlwns33 added the Feat 새로운 기능 구현 label Dec 25, 2021
@dlwns33 dlwns33 self-assigned this Dec 25, 2021
// TODO: 그룹 변경 서버통신
hideBottomSheetAndGoBack()
// 그룹 변경 서버통신
print(selectedGroup)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이거 비롯해서 switch 문 안의 프린트문 지워줘도 될거같아용

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

네 주석 제거 한번더 처리하겠숨당!!

Comment on lines +78 to +79
// groupAddWithAPI(groupRequest: GroupAddRequest(userId: UserDefaults.standard.string(forKey: Const.UserDefaults.userID) ?? "",
// groupName: "SOPT"))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

테스트 끝났으면 정리해주세욥!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

앗 요거는 제가 임의로 그룹 추가할때 포스트맨 대신 서버 붙인걸로 쏜거라서... 민재가 아마 그룹 추가할때 필요할거에욤 !!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아아 그래욥! 최고!

if !group.groups.isEmpty {
// self.cardListInGroupWithAPI(cardListInGroupRequest: CardListInGroupRequest(userId: "nada2", groupId: group.groups[0].groupID, offset: 0))
self.cardListInGroupWithAPI(cardListInGroupRequest: CardListInGroupRequest(userId: UserDefaults.standard.string(forKey: Const.UserDefaults.userID) ?? "", groupId: group.groups[0].groupID, offset: 0))
self.cardListInGroupWithAPI(cardListInGroupRequest: CardListInGroupRequest(userId: UserDefaults.standard.string(forKey: Const.UserDefaults.userID) ?? "", groupId: group.groups[self.selectedRow].groupID, offset: 0))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

일단 오프셋 0으로 확인요!! 수고했습니당

Copy link
Member

@hyun99999 hyun99999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

지금 스샷에서 미분류에 있는 카드가 대학 분류에도 등장하는 듯한데 중복되는 카드인가요? 확인부탁드립니당!

@dlwns33
Copy link
Member Author

dlwns33 commented Dec 25, 2021

지금 스샷에서 미분류에 있는 카드가 대학 분류에도 등장하는 듯한데 중복되는 카드인가요? 확인부탁드립니당!

저두 그런줄 알았느데 카드 아이디가 다른걸로 봐서 다른 카드인거같습니다! 훼이크..

@dlwns33 dlwns33 merged commit 58a5ff0 into TeamNADA:release1.0/2 Dec 25, 2021
@dlwns33 dlwns33 deleted the release/#219 branch December 25, 2021 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feat 새로운 기능 구현
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] 명함 그룹 수정 서버
2 participants