Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] #184 - 리스트뷰, 메인 일부 서버 연결 #225

Merged
merged 28 commits into from
Dec 26, 2021

Conversation

mini-min
Copy link
Member

🌴 PR 요약

🌱 작업한 브랜치

🌱 작업한 내용
늦어서 죄송합니다 교수님덜😭😭

  • 메인 서버 일부 -> 무한 스크롤 이전까지
  • 리스트 조회 서버 연결
  • 명함 삭제 서버 연결
  • 명함 편집 서버 연결 -> 핀 고정시, 드래그 수정시 모두
  • 기타 -> 리스트에서 핀된 명함은 삭제 스와이프가 되지 않도록 로직 변경
  • 기타 -> 스플래시와 관련된 부분은 작업 중인게 잘못 넘어왔습니다! 그냥 넘겨주시면 됩니다~~

📸 스크린샷

기능 스크린샷
GIF 제 맥북에서는 왜 카카오톡과 애플 로그인이 안되는지 모르겠,,

📮 관련 이슈

@mini-min mini-min added Minjae 🐻‍❄️ 민재 강남1타강사 작업 P1 / Priority High 우선순위 높음 Feat 새로운 기능 구현 labels Dec 26, 2021
@mini-min mini-min self-assigned this Dec 26, 2021
Comment on lines +52 to +71
if isList == true {
switch result {
case .success(let response):
let statusCode = response.statusCode
let data = response.data

let networkResult = self.judgeCardListFetchStatus(by: statusCode, data)
completion(networkResult)

case .failure(let err):
print(err)
}
} else {
switch result {
case .success(let response):
let statusCode = response.statusCode
let data = response.data

let networkResult = self.judgeMainListFetchStatus(by: statusCode, data)
completion(networkResult)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 추가하셨군요!

Comment on lines +114 to +116
case .cardDetailFetch, .cardListFetch, .cardDelete, .cardListEdit:
return ["Content-Type": "application/json",
"Authorization": "Bearer " + UserDefaults.standard.string(forKey: Const.UserDefaults.accessToken)!]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이제 const 에 선언해둔거 지우고 이렇게 코드 바꾸기 시작하면 될거 같아여

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

넴넴!

Comment on lines 70 to 71
} else {

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기부분에 65 번 66 번 코드를 넣으면 될거 같네용

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아 맞네요!!! ㅋㅌㅋㅌㅋㅌㅋ쓰고 까먹어버렸...감사합니돠

Comment on lines +108 to +116
func changeRootViewController(_ viewControllerToPresent: UIViewController) {
if let window = UIApplication.shared.windows.first {
window.rootViewController = viewControllerToPresent
UIView.transition(with: window, duration: 0.5, options: .transitionCrossDissolve, animations: nil)
} else {
viewControllerToPresent.modalPresentationStyle = .overFullScreen
self.present(viewControllerToPresent, animated: true, completion: nil)
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굳굳 고민 많이 하셨을거 같네여!

@mini-min mini-min merged commit 4f37565 into TeamNADA:release1.0/2 Dec 26, 2021
@mini-min mini-min deleted the release/#184 branch December 26, 2021 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feat 새로운 기능 구현 Minjae 🐻‍❄️ 민재 강남1타강사 작업 P1 / Priority High 우선순위 높음
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] 메인, 리스트 서버 연결
2 participants