-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] #226 - 메인 무한스크롤 구현 및 data 모델 정리 #227
Conversation
- 메인스크롤 구현 - data 모델 정리 - CardClass 삭제 - MainListRequest 삭제(사용하지 않음)
- viewWillAppear 일때 메인 카드 리스트 서버통신
…orRelease into release1.0/#226 # Conflicts: # NADA-iOS-forRelease/Sources/ViewControllers/Main/FrontViewController.swift
- offset nil 일 경우 처리
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
변경 확인했습니다! 코리뷰 확인해주시고 머지해두될거 같아욥!
주신질문: cardListFetch 에서 offset nil 일 경우 "" 빈문자열로 대체했는데 이렇게 하면 괜찮죠?
답: 넵!
|
||
private func setUI() { | ||
|
||
} | ||
|
||
func navigationBackSwipeMotion() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
어이쿠 정리까지 감사합니다
|
||
func didScroll(verticalCardSwiperView: VerticalCardSwiperView) { | ||
if verticalCardSwiperView.contentOffset.y > verticalCardSwiperView.contentSize.height - verticalCardSwiperView.bounds.height { | ||
if isInfiniteScroll { | ||
isInfiniteScroll = false | ||
offset += 1 | ||
guard let userID = userID else { return } | ||
cardListFetchWithAPI(userID: userID, isList: false, offset: offset) | ||
} | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
// FIXME: - 로그 확인용. | ||
// print("✅cardListLookUpRequest", cardListLookUpRequest) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이제 FIXME 지워도 될것 같습니다!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
넵! 근데 지금 이게 뭔가 완벽한 로직은 아니라... 일단 남겨뒀습니당!
슬랙 예원이한테 질문한거랑 연관있어염
@@ -115,12 +142,16 @@ extension FrontViewController: VerticalCardSwiperDatasource { | |||
// MARK: - Network | |||
extension FrontViewController { | |||
func cardListFetchWithAPI(userID: String, isList: Bool, offset: Int) { | |||
CardAPI.shared.cardListFetch(userID: userID, isList: isList, offset: offset) { response in | |||
CardAPI.shared.cardListFetch(userID: "nada2", isList: isList, offset: offset) { response in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
일부러 nada2
로 고정해두신가요 지금은??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
넵 이슈파고 헤더 이제 동적으로 설정하면서 요것도 설정해둘게요! 굳굳!
// MARK: - DataClass | ||
struct CardClass: Codable { | ||
let card: Card | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
확인이욥
🌴 PR 요약
🌱 작업한 브랜치
🌱 작업한 내용
@mini-min 선생님
cardListFetch
에서 offset nil 일 경우 "" 빈문자열로 대체했는데 이렇게 하면 괜찮죠?📸 스크린샷
📮 관련 이슈