[FEAT] #226 - 메인 무한스크롤 구현 및 data 모델 정리 #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 메인스크롤 구현 - data 모델 정리 - CardClass 삭제 - MainListRequest 삭제(사용하지 않음)
- viewWillAppear 일때 메인 카드 리스트 서버통신
…orRelease into release1.0/#226 # Conflicts: # NADA-iOS-forRelease/Sources/ViewControllers/Main/FrontViewController.swift
- offset nil 일 경우 처리
mini-min
approved these changes
Dec 26, 2021
Comment on lines
-134
to
131
|
|
||
| private func setUI() { | ||
|
|
||
| } | ||
|
|
||
| func navigationBackSwipeMotion() { |
Comment on lines
+104
to
+114
|
|
||
| func didScroll(verticalCardSwiperView: VerticalCardSwiperView) { | ||
| if verticalCardSwiperView.contentOffset.y > verticalCardSwiperView.contentSize.height - verticalCardSwiperView.bounds.height { | ||
| if isInfiniteScroll { | ||
| isInfiniteScroll = false | ||
| offset += 1 | ||
| guard let userID = userID else { return } | ||
| cardListFetchWithAPI(userID: userID, isList: false, offset: offset) | ||
| } | ||
| } | ||
| } |
Comment on lines
+151
to
+152
| // FIXME: - 로그 확인용. | ||
| // print("✅cardListLookUpRequest", cardListLookUpRequest) |
There was a problem hiding this comment.
넵! 근데 지금 이게 뭔가 완벽한 로직은 아니라... 일단 남겨뒀습니당!
슬랙 예원이한테 질문한거랑 연관있어염
| @@ -115,12 +142,16 @@ extension FrontViewController: VerticalCardSwiperDatasource { | |||
| // MARK: - Network | |||
| extension FrontViewController { | |||
| func cardListFetchWithAPI(userID: String, isList: Bool, offset: Int) { | |||
| CardAPI.shared.cardListFetch(userID: userID, isList: isList, offset: offset) { response in | |||
| CardAPI.shared.cardListFetch(userID: "nada2", isList: isList, offset: offset) { response in | |||
There was a problem hiding this comment.
넵 이슈파고 헤더 이제 동적으로 설정하면서 요것도 설정해둘게요! 굳굳!
Comment on lines
-10
to
-14
| // MARK: - DataClass | ||
| struct CardClass: Codable { | ||
| let card: Card | ||
| } | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌴 PR 요약
🌱 작업한 브랜치
🌱 작업한 내용
@mini-min 선생님
cardListFetch에서 offset nil 일 경우 "" 빈문자열로 대체했는데 이렇게 하면 괜찮죠?📸 스크린샷
📮 관련 이슈