Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#22] initializer 메서드 컨밴션에 맞춰 네이밍 변경 및 cell 리펙토링 #23

Merged
merged 1 commit into from
Oct 2, 2021

Conversation

hyun99999
Copy link
Member

🌴 PR 요약

🌱 작업한 브랜치

🌱 작업한 내용

  • 메서드명 prefix 를 'init' 으로 수정
  • 셀마다 nib() 메서드 생성
  • Xib 구조체 만들어서 상수로 identifier 다룸

📸 스크린샷

기능 스크린샷
GIF 파일첨부바람

📮 관련 이슈

### Descriptions
- 메서드명 prefix 를 'init' 으로 수정
- 셀마다 nib() 메서드 생성
- Xib 구조체 만들어서 상수로 identifier 다룸

### Related Issue
close TeamNADA#22
@hyun99999 hyun99999 added Hyungyu 🐯 현규 교수님 작업 Refactor 로직은 변경하지 않고, 기존의 코드를 개선하는 리펙토링 labels Oct 2, 2021
@hyun99999 hyun99999 self-assigned this Oct 2, 2021
Copy link
Member

@mini-min mini-min left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍🏻

requiredCollectionView.register(RequiredFlavorCollectionViewCell.nib(), forCellWithReuseIdentifier: Const.Xib.requiredCollectionViewCell)
}
static func nib() -> UINib {
return UINib(nibName: "BackCardCreationCollectionViewCell", bundle: nil)
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

크으 뿌듯합니다

@mini-min mini-min merged commit 4ae488f into TeamNADA:develop Oct 2, 2021
@hyun99999 hyun99999 deleted the feature/#22 branch October 2, 2021 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hyungyu 🐯 현규 교수님 작업 Refactor 로직은 변경하지 않고, 기존의 코드를 개선하는 리펙토링
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REFACTOR] initializer 메서드 컨밴션에 맞춰 네이밍 변경 및 cell 리펙토링
2 participants