Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] #221 - 명함 궁합 서버 #231

Merged
merged 9 commits into from
Dec 26, 2021

Conversation

dlwns33
Copy link
Member

@dlwns33 dlwns33 commented Dec 26, 2021

🌴 PR 요약

🌱 작업한 브랜치

🌱 작업한 내용

  • 궁합 서버를 붙였습니다!
  • 지금은 서버에서 가져오는 시간이 빨라서 따로 빙글빙글 로딩은 넣지 않았는데, 기획의도에 맞추어 나중에 디벨롭 해보겠습니다!

📸 스크린샷

기능 스크린샷
전체 뷰 Simulator Screen Shot - iPhone 12 mini - 2021-12-27 at 02 04 48

📮 관련 이슈

@dlwns33 dlwns33 added Yijoon 🐨 이준 대치동강사 작업 Feat 새로운 기능 구현 labels Dec 26, 2021
@dlwns33 dlwns33 self-assigned this Dec 26, 2021
Comment on lines 12 to 21
struct HarmonyResponse: Codable {
let harmony: Int
}

struct HarmonyData {
let icon: String
let percentage: String
let color: UIColor
let description: String
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

enum codingkeys 추가해주세욥!

Comment on lines 14 to 15
// var utilProvider = MoyaProvider<UtilService>(plugins: [MoyaLoggerPlugin()])
var utilProvider = MoyaProvider<UtilService>()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

주석정리해주세욥!

Copy link
Member

@mini-min mini-min left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굳굳 이준선배👍🏻

@@ -1200,6 +1211,8 @@
393E3345275F69EE00965BBF /* SplashViewController.swift in Sources */,
F8C83FB8272F9E3F0009DF0D /* UtilAPI.swift in Sources */,
F8FC438826C01CDD0033E151 /* SceneDelegate.swift in Sources */,
39288E12273F52B20072F403 /* CardListLookUpRequest.swift in Sources */,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

얘는 뭘까용.......?

@dlwns33 dlwns33 merged commit 8041ee5 into TeamNADA:release1.0/2 Dec 26, 2021
@dlwns33 dlwns33 deleted the release/#221 branch December 26, 2021 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feat 새로운 기능 구현 Yijoon 🐨 이준 대치동강사 작업
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] 명함 궁합 서버
3 participants