[FIX] #253 - 카카오톡 로그인 post 서버 통신 시, oauthToken을 사용하도록 변경 #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mini-min
added
Minjae 🐻❄️
hyun99999
approved these changes
Dec 28, 2021
Comment on lines
+138
to
+141
| if let token = oauthToken?.accessToken { | ||
| self.postUserSignUpWithAPI(request: token) | ||
| UserDefaults.standard.set(false, forKey: Const.UserDefaultsKey.isAppleLogin) | ||
| UserDefaults.standard.set(true, forKey: Const.UserDefaultsKey.isKakaoLogin) |
There was a problem hiding this comment.
loginWithApp 메서드에서도 token 을 다루어야 할거 같아요! 그리고 userDefaults 에 저장해주세요!
There was a problem hiding this comment.
앗 감사합니다 급해서 ^__^
userDefaults에는 통신하고 토큰값이랑 일괄적으로 아이디도 담고있습니다!
hyun99999
reviewed
Dec 29, 2021
Comment on lines
+111
to
+118
| UserApi.shared.me {(_, error) in | ||
| if let error = error { | ||
| print(error) | ||
| } else { | ||
| if let email = user?.kakaoAccount?.email { | ||
| self.postUserSignUpWithAPI(request: email) | ||
| if let token = oauthToken?.accessToken { | ||
| self.postUserSignUpWithAPI(request: token) | ||
| UserDefaults.standard.set(false, forKey: Const.UserDefaultsKey.isAppleLogin) | ||
| UserDefaults.standard.set(true, forKey: Const.UserDefaultsKey.isKakaoLogin) |
There was a problem hiding this comment.
@mini-min 지금 뒤늦게 또 보고있는데 UserAPI.shared.me 는 사용자 정보를 가져오는거라서 우리는 굳이 안가져오니까 이 코드는 사용하지 않아도 될거 같아요....!
하지만 있어도 문제없는 코드니까 민재도 알고 넘어가면 될거 같네요!
Comment on lines
+138
to
+141
| if let token = oauthToken?.accessToken { | ||
| self.postUserSignUpWithAPI(request: token) | ||
| UserDefaults.standard.set(false, forKey: Const.UserDefaultsKey.isAppleLogin) | ||
| UserDefaults.standard.set(true, forKey: Const.UserDefaultsKey.isKakaoLogin) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌴 PR 요약
🌱 작업한 브랜치
🌱 작업한 내용
email사용 ->oauthToken?.accessToken사용으로 변경📮 관련 이슈