-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] #257 - 명함 그룹뷰 인파이나이트스크롤 구현 #261
Conversation
- prepareForReuse 로 셀 초기화 - 명함 추가, 명함큐알 추가, 명함삭제, 큐알스캔 뒤로가기, 그룹 편집 뒤로가기 시에 그룹뷰 갱신 노티 추가 - viewWillAppear 에서 구현할라했지만 컬렉션뷰 맨 위로 올리는 과정이 추가되기 위해서 노티 사용 - 무한스크롤 구현 - 현재 맨 위로 올리기 위해서 1초의 딜레이를 주고 있는데 좀 더 고민해보겠습니당
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
감사합니다!
override func prepareForReuse() { | ||
super.prepareForReuse() | ||
|
||
backgroundImageView.image = UIImage() | ||
titleLabel.text = "" | ||
descriptionLabel.text = "" | ||
userNameLabel.text = "" | ||
birthLabel.text = "" | ||
mbtiLabel.text = "" | ||
instagramIDLabel.text = "" | ||
mbtiLabel.text = "" | ||
instagramIcon.image = UIImage() | ||
urlIcon.image = UIImage() | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아 세심하네요 좋아좋아
@@ -63,32 +63,22 @@ class GroupViewController: UIViewController { | |||
|
|||
// 그룹 이름들을 담을 변수 생성 | |||
var serverGroups: Groups? | |||
var serverCards: CardsInGroupResponse? | |||
var frontCards: [FrontCard]? = [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
감사합니다..
} | ||
|
||
extension QRScanViewController { | ||
@objc func dismissQRScanViewController() { | ||
NotificationCenter.default.post(name: .reloadGroupViewController, object: nil) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
요것도 감사합니다..
@@ -107,9 +97,26 @@ extension GroupViewController { | |||
navigationController?.navigationBar.isHidden = true | |||
} | |||
|
|||
private func setNotification() { | |||
NotificationCenter.default.addObserver(self, selector: #selector(didRecieveDataNotification(_:)), name: Notification.Name.passDataToGroup, object: nil) | |||
NotificationCenter.default.addObserver(self, selector: #selector(scrollToTop), name: .reloadGroupViewController, object: nil) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
요 reloadGRoupViewController은 Notification.Name안해두 먹히나요??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🌴 PR 요약
🌱 작업한 브랜치
🌱 작업한 내용
📮 관련 이슈