Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] #267 - 리스트, 그룹 편집 엠티뷰 추가 #268

Merged
merged 3 commits into from
Dec 29, 2021

Conversation

mini-min
Copy link
Member

🌴 PR 요약

🌱 작업한 브랜치

🌱 작업한 내용

  • 카드 리스트 엠티뷰 추가
  • 그룹 편집 엠티뷰 추가

📸 스크린샷

기능 스크린샷 기능 스크린샷
리스트 simulator_screenshot_A26F8D0B-5D87-4A56-B776-482369EEA24E 그룹편집 simulator_screenshot_CCA1DF2B-A34C-486E-B7FE-C4FDE1E696B7

📮 관련 이슈

@mini-min mini-min added Minjae 🐻‍❄️ 민재 강남1타강사 작업 P1 / Priority High 우선순위 높음 Feat 새로운 기능 구현 labels Dec 29, 2021
@mini-min mini-min self-assigned this Dec 29, 2021
Copy link
Member

@dlwns33 dlwns33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고해쓰요!

serviceCell.initData(title: serverGroups?.groups[indexPath.row].groupName ?? "")

return serviceCell
if serverGroups?.groups.isEmpty == true {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

요거 == true는 빼도 돌아갈거 같아여!! 일단 킵 !!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

serverGroupsr가 옵셔널 변수라 이렇게 선언해줘야 한다고 합니다!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

앗 오케이 입니당!! 굿굿

Copy link
Member

@hyun99999 hyun99999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍LZTM

@mini-min mini-min merged commit b14eadf into TeamNADA:release1.0/3 Dec 29, 2021
@mini-min mini-min deleted the release/#267 branch December 29, 2021 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feat 새로운 기능 구현 Minjae 🐻‍❄️ 민재 강남1타강사 작업 P1 / Priority High 우선순위 높음
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] 리스트, 그룹 편집 엠티뷰 추가
3 participants