-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 앱 내에서 동적링크 생성 (#338) #341
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 충분히 함수명으로 역할을 알 수 있기 때문에 불필요한 주석이라고 판단했습니다.
- SelectBirthBottomViewController, CardShareBottomSheetViewController 해당하는 수정
- 동적 링크라서 딥링크는 이미 지원하기 때문에 굳이 URl Scheme 설정해줄 필요가 없었다. 파이어베이스 iOS 앱에 팀ID 를 설정하고 시간이 지나면서 동적 링크가 유효해져서 정상 작동을 확인하였다.
dlwns33
approved these changes
Jan 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
확인했습니다! 파이어베이스로 동적링크를 생성하는군요.. 하나 또 배워갑니다🙇♀️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌴 PR 요약
🌱 작업한 브랜치
🌱 작업한 내용
🚨 참고사항
associated domain 을 추가했는데도 앱이 설치되었을 때 앱이 아닌 앱스토어로 보내고 있습니다. 이는 동적 링크를 잘 못 생성했을 가능성이 있기 때문에 다른 이슈를 파서 진행하겠습니다.동적 링크를 만드는 과정은 아래 노션에 첨부하겠습니다.
https://www.notion.so/iOS-Firebase-Dynamic-Link-7d473b325ff94b889285cf1871c784e9
RPReplay_Final1672927791.MP4
RPReplay_Final1672927773.MP4
프로젝트에는 주석이 불필요할거 같아서 여기에 주석을 달아두었습니다!
📸 스크린샷
📮 관련 이슈