-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 명함 공유 뷰 수정 (#349) #350
Merged
Merged
Commits on Jan 18, 2023
-
Merge branch 'feature/#347' of https://github.com/TeamNADA/NADA-iOS-F…
…orRelease into feature/#349
Configuration menu - View commit details
-
Copy full SHA for 2885740 - Browse repository at this point
Copy the full SHA 2885740View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3ba5ff1 - Browse repository at this point
Copy the full SHA 3ba5ff1View commit details -
Configuration menu - View commit details
-
Copy full SHA for ad541d8 - Browse repository at this point
Copy the full SHA ad541d8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6e103d4 - Browse repository at this point
Copy the full SHA 6e103d4View commit details -
feat: UIView Extension 추가 (#349)
- layout 작업 시에 UIView 배열로 뷰에 더하는 함수 생성.
Configuration menu - View commit details
-
Copy full SHA for a5beac6 - Browse repository at this point
Copy the full SHA a5beac6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 33a315e - Browse repository at this point
Copy the full SHA 33a315eView commit details -
Configuration menu - View commit details
-
Copy full SHA for cc27170 - Browse repository at this point
Copy the full SHA cc27170View commit details -
Configuration menu - View commit details
-
Copy full SHA for d3cfebe - Browse repository at this point
Copy the full SHA d3cfebeView commit details -
feat: 명함 활성화 유무에 따른 UI 구현 (#349)
- if 문을 사용하게 되면 줄이 두배 길어지고, 삼항연산자 사용하면 UI components 에 코드가 집중할 수 있다고 생각했습니다. - if-else 문에서 휴먼에러로 변경되는 UI 를 놓치지 않을 수 있습니다.
Configuration menu - View commit details
-
Copy full SHA for 7280ee9 - Browse repository at this point
Copy the full SHA 7280ee9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6ea26dc - Browse repository at this point
Copy the full SHA 6ea26dcView commit details -
Configuration menu - View commit details
-
Copy full SHA for c2c79a8 - Browse repository at this point
Copy the full SHA c2c79a8View commit details -
Configuration menu - View commit details
-
Copy full SHA for d841a23 - Browse repository at this point
Copy the full SHA d841a23View commit details -
Configuration menu - View commit details
-
Copy full SHA for 861ec6d - Browse repository at this point
Copy the full SHA 861ec6dView commit details -
Configuration menu - View commit details
-
Copy full SHA for e5785b6 - Browse repository at this point
Copy the full SHA e5785b6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 64c48a4 - Browse repository at this point
Copy the full SHA 64c48a4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0ae2411 - Browse repository at this point
Copy the full SHA 0ae2411View commit details -
Configuration menu - View commit details
-
Copy full SHA for 14e5657 - Browse repository at this point
Copy the full SHA 14e5657View commit details
Commits on Jan 19, 2023
-
- lazy 로 선언해서 lottie image 를 사용하기 전까지 메모리에 올리지 않게 됨.
Configuration menu - View commit details
-
Copy full SHA for 74073da - Browse repository at this point
Copy the full SHA 74073daView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8c0040c - Browse repository at this point
Copy the full SHA 8c0040cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 32632a8 - Browse repository at this point
Copy the full SHA 32632a8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 857bb48 - Browse repository at this point
Copy the full SHA 857bb48View commit details -
refactor: SwiftLint (self_in_property_initialization) 워닝 제거 (#349)
- 아직 선언되지 않은 컴포넌트의 액션 메서드를 적용하기 위해서 addTarget() 에서 self 를 사용하면 이는 예상못할 수 있기 때문에 lazy 하게 만들어야 안전합니다.
Configuration menu - View commit details
-
Copy full SHA for e67e4c7 - Browse repository at this point
Copy the full SHA e67e4c7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4127d92 - Browse repository at this point
Copy the full SHA 4127d92View commit details
Commits on Jan 25, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 99c3f33 - Browse repository at this point
Copy the full SHA 99c3f33View commit details
Commits on Jan 27, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 6dafb5f - Browse repository at this point
Copy the full SHA 6dafb5fView commit details
Commits on Jan 30, 2023
-
Configuration menu - View commit details
-
Copy full SHA for fa04290 - Browse repository at this point
Copy the full SHA fa04290View commit details
Commits on Jan 31, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 82d5ef4 - Browse repository at this point
Copy the full SHA 82d5ef4View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.