Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 명함 공유 뷰 수정 (#349) #350

Merged
merged 27 commits into from
Jan 31, 2023
Merged

fix: 명함 공유 뷰 수정 (#349) #350

merged 27 commits into from
Jan 31, 2023

Commits on Jan 18, 2023

  1. Merge branch 'feature/#347' of https://github.com/TeamNADA/NADA-iOS-F… 

    …orRelease into feature/#349
    @hyun99999
    hyun99999 committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    2885740 View commit details
    Browse the repository at this point in the history

  2. add: 명함 공유 바텀시트를 위한 이미지 에셋 추가 (#349)

    @hyun99999
    hyun99999 committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    3ba5ff1 View commit details
    Browse the repository at this point in the history

  3. chore: pod update (#349)

    @hyun99999
    hyun99999 committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    ad541d8 View commit details
    Browse the repository at this point in the history

  4. fix: 바텀시트 높이 변경 (#349)

    @hyun99999
    hyun99999 committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    6e103d4 View commit details
    Browse the repository at this point in the history

  5. feat: UIView Extension 추가 (#349) 

    - layout 작업 시에 UIView 배열로 뷰에 더하는 함수 생성.
    @hyun99999
    hyun99999 committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    a5beac6 View commit details
    Browse the repository at this point in the history

  6. feat: addSubviews(_:) 함수 적용 (#349)

    @hyun99999
    hyun99999 committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    33a315e View commit details
    Browse the repository at this point in the history

  7. refactor: 접근 제어자 수정 (#349)

    @hyun99999
    hyun99999 committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    cc27170 View commit details
    Browse the repository at this point in the history

  8. add: UI Components 추가 (#349)

    @hyun99999
    hyun99999 committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    d3cfebe View commit details
    Browse the repository at this point in the history

  9. feat: 명함 활성화 유무에 따른 UI 구현 (#349) 

    - if 문을 사용하게 되면 줄이 두배 길어지고, 삼항연산자 사용하면 UI components 에 코드가 집중할 수 있다고 생각했습니다.
- if-else 문에서 휴먼에러로 변경되는 UI 를 놓치지 않을 수 있습니다.
    @hyun99999
    hyun99999 committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    7280ee9 View commit details
    Browse the repository at this point in the history

  10. delete: FIXME 주석 삭제 (#349)

    @hyun99999
    hyun99999 committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    6ea26dc View commit details
    Browse the repository at this point in the history

  11. fix: 명함 공유 바텀시트의 수정으로 QR Code 의 배경 변경 (#349)

    @hyun99999
    hyun99999 committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    c2c79a8 View commit details
    Browse the repository at this point in the history

  12. fix: QR Code 크기 변경 (#349)

    @hyun99999
    hyun99999 committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    d841a23 View commit details
    Browse the repository at this point in the history

  13. design: UI layout 수정 (#349)

    @hyun99999
    hyun99999 committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    861ec6d View commit details
    Browse the repository at this point in the history

  14. feat: nearBySwitch 의 액션 메서드 구현 (#349)

    @hyun99999
    hyun99999 committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    e5785b6 View commit details
    Browse the repository at this point in the history

  15. refactor: 삼항연산자 사용한 nearBySwitch 액션메서드 리펙토링 (#349)

    @hyun99999
    hyun99999 committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    64c48a4 View commit details
    Browse the repository at this point in the history

  16. chore: import Lottie (#349)

    @hyun99999
    hyun99999 committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    0ae2411 View commit details
    Browse the repository at this point in the history

  17. feat: 명함 공유 바텀시트가 가지는 변수 설정 (#349) 

    - 추후에 수정되어야 하기 때문에 주석 설정.
    @hyun99999
    hyun99999 committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    14e5657 View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2023

  1. add: lottieImage 추가 (#349) 

    - lazy 로 선언해서 lottie image 를 사용하기 전까지 메모리에 올리지 않게 됨.
    @hyun99999
    hyun99999 committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    74073da View commit details
    Browse the repository at this point in the history

  2. design: lottieImage 레이아웃 설정 (#349)

    @hyun99999
    hyun99999 committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    8c0040c View commit details
    Browse the repository at this point in the history

  3. feat: isActivate 변수에 따른 UI 설정 (#349)

    @hyun99999
    hyun99999 committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    32632a8 View commit details
    Browse the repository at this point in the history

  4. feat: nearBySwitch 액션 메서드에 lottieImage 설정 추가 (#349)

    @hyun99999
    hyun99999 committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    857bb48 View commit details
    Browse the repository at this point in the history

  5. refactor: SwiftLint (self_in_property_initialization) 워닝 제거 (#349) 

    - 아직 선언되지 않은 컴포넌트의 액션 메서드를 적용하기 위해서 addTarget() 에서 self 를 사용하면 이는 예상못할 수 있기 때문에 lazy 하게 만들어야 안전합니다.
    @hyun99999
    hyun99999 committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    e67e4c7 View commit details
    Browse the repository at this point in the history

  6. refactor: 명함의 활성화 유무를 가지고 UI 를 설정해주는 함수로 리펙토링 (#349)

    @hyun99999
    hyun99999 committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    4127d92 View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2023

  1. Merge branch 'develop' of https://github.com/TeamNADA/NADA-iOS-ForRel… 

    …ease into feature/#349
    @hyun99999
    hyun99999 committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    99c3f33 View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2023

  1. chore: Podfile 특정 버전 다운로드하는 옵션 삭제 (#349)

    @hyun99999
    hyun99999 committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    6dafb5f View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2023

  1. chore: GoogleService-info.plist 파일이 빠져있어 다시 추가 (#349)

    @hyun99999
    hyun99999 committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    fa04290 View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2023

  1. Merge branch 'develop' of https://github.com/TeamNADA/NADA-iOS-ForRel… 

    …ease into feature/#349

# Conflicts:
#	NADA-iOS-forRelease.xcodeproj/project.pbxproj
    @hyun99999
    hyun99999 committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    82d5ef4 View commit details
    Browse the repository at this point in the history