-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 기본 명함 앞면 수정 (#353) #354
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고하셨씁니다!
@@ -114,7 +115,7 @@ extension FrontCardCreationCollectionViewCell { | |||
birthView.backgroundColor = .textBox | |||
birthLabel.font = .textRegular04 | |||
birthLabel.textColor = .quaternary | |||
birthLabel.text = "생년월일" | |||
birthLabel.text = "생일" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
요거는 그냥 생각나서 이곳에 적어봅니당 !
하지 않을수도 있지만 나중에 localization을 하게 되면 요런것들이 다 영어로 보여야 하잖아요..?
그래서 요런 것들을 StringLiterals에 모아두는것도 좋을 것 같아요.
관련링크 첨부하겠습니다!
https://i-colours-u.tistory.com/22
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
캬.. 여기서 그분의.. 블로그라니 좋습니다.. 이준이 영어로 쓰죠? 폰 ㅋㅋㅋㅋ
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이 작업도 추후에 해보자구용
🌴 PR 요약
🌱 작업한 브랜치
🌱 작업한 내용
🚨 참고사항
📸 스크린샷
📮 관련 이슈