-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 취향 조회 API 로 명함 생성 뒷면 구성 (#393) #395
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 필수 정보를 [String], 옵션 정보를 String 으로 전달.
- 리펙토링 및 UI 변경으로 수정. - initCell 메서드 수정
- FrontCardDataModel 와 BackCardDataModel 수정 - delegate 파라미터 자료형도 수정
- UI 수정 및 기능 구현
hyun99999
changed the title
feat: 취향 조회 API 로 명함 생성 뒷면 구성
feat: 취향 조회 API 로 명함 생성 뒷면 구성 (#393)
Apr 2, 2023
- [Card] 로 대체해서 사용할 것이기 때문에 삭제. offset 은 더이상 응답에 없음.
dlwns33
approved these changes
Apr 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
선생님 코드 다 읽어봤습니다!
뒷면 수정을 다 해주셨네요... 수고하셨습니다
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌴 PR 요약
🌱 작업한 브랜치
🌱 작업한 내용
🚨 참고사항
📮 관련 이슈