-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 명함 조회 API 수정 (#384) #398
Conversation
- 기본 파라미터를 사용해서 옵셔널 바인딩 로직을 활용하여 Service 파일에서 로직 구현.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let nextVC = CardResultBottomSheetViewController() | ||
.setTitle(card.userName) | ||
.setHeight(574) | ||
nextVC.cardDataModel = card | ||
nextVC.modalPresentationStyle = .overFullScreen | ||
nextVC.status = .addWithQR | ||
self.present(nextVC, animated: false, completion: nil) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
요것도 나중에 moduleFactory 에서 관리하는것으로 변환하면 좋을 것 같아요!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
!!! 넵!!!
🌴 PR 요약
🌱 작업한 브랜치
🌱 작업한 내용
🚨 참고사항
judgeCardListFetchStatus
메서드를 주석처리하였습니당📮 관련 이슈