Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 홈 화면 바텀시트 UI #403 #405

Merged
merged 14 commits into from
Apr 14, 2023
Merged

Conversation

dlwns33
Copy link
Member

@dlwns33 dlwns33 commented Apr 11, 2023

🌴 PR 요약

🌱 작업한 브랜치

🌱 작업한 내용

  • 홈 화면 바텀시트 UI 만들기
  • 해당화면 연결하기
  • 홈 아이콘 업데이트 하기
  • 몇몇 빠진 다크모드 대응하기

📸 스크린샷

기능 스크린샷 기능 스크린샷
바텀시트 simulator_screenshot_9C642941-89E0-49C0-A2E5-47337C6B5875 아이콘 변경 simulator_screenshot_C9858C3B-6661-42D8-8925-11B59462DDA5

📮 관련 이슈

@dlwns33 dlwns33 added Yijoon 🐨 이준 대치동강사 작업 Feat 새로운 기능 구현 labels Apr 11, 2023
@dlwns33 dlwns33 requested a review from hyun99999 April 11, 2023 15:02
@dlwns33 dlwns33 self-assigned this Apr 11, 2023
Copy link
Member

@hyun99999 hyun99999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니당

Comment on lines 193 to 206
@nonobjc class var homeViews: UIColor {
if #available(iOS 13, *) {
return UIColor { (traitCollection: UITraitCollection) -> UIColor in
if traitCollection.userInterfaceStyle == .light {
return UIColor(red: 224.0 / 255.0, green: 232.0 / 255.0, blue: 239.0 / 255.0, alpha: 1.0)
} else {
return UIColor(red: 64.0 / 255.0, green: 70.0 / 255.0, blue: 79.0 / 255.0, alpha: 1.0)
}
}
} else {
return UIColor(red: 233.0 / 255.0, green: 236.0 / 255.0, blue: 239.0 / 255.0, alpha: 1.0)
}
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cardCreationUnclicked 랑 cardCreationClicked 를 만들어뒀는데 같은 배경색이라서 요거 사용하면 될거 같아요!
채쌤이 눌렸을때 눌린티 내달라고해서 cardCreationClicked 만들어뒀었는데 여기에도 적용해두면 좋지 않을까.. 싶습니다..

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아 이미지뷰에서 그냥 뷰로 바꾸는 작업중에 같은 색깔인지 인지를 못하고 있었네여 !!!!
반영하겠습니다! (엑코업데이트 끝나면......🔫)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

엌ㅋㅋㅋ 엑코 업뎃👍

}
}

// MARK: - Methods

private func bindActions() {
giveCardImageView.rx.tapGesture()
giveCardView.rx.tapGesture()
.when(.recognized) // bind시에도 이벤트가 발생하기 때문 .skip(1)으로도 처리 가능
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

중복되는 주석을 삭제해도 될거 같아용!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

넵 반영했습니당!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!

@dlwns33 dlwns33 merged commit e0c9837 into TeamNADA:develop Apr 14, 2023
@dlwns33 dlwns33 deleted the feature/#403 branch April 14, 2023 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feat 새로운 기능 구현 Yijoon 🐨 이준 대치동강사 작업
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: 홈 화면 바텀시트 UI
2 participants