-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] #36 - 커스텀 탭바 구현, 연결 #41
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
와.. 델리게이트도 만들고.. 민재교수님 멋집니다!
중간중간 리뷰남긴거 답남겨주시구 수정이 필요한 부분이 있다면 수정해서 푸쉬한다음에 머지해도 좋을거같아요! 😎
@@ -3,6 +3,7 @@ disabled_rules: | |||
- trailing_whitespace | |||
- nesting | |||
- function_parameter_count | |||
- identifier_name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이건 혹시 왜 추가했나요?! 대문자 시작 워닝안하게 하려한건가?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
저게 글자수 3글자 이상이어야 하는건데, 뷰컨이나 NSLayoutConstraint 이름 vc, cr이렇게 되어있던거 워닝떠서 추가했습니다 ^__^
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
음..! 최대한으로 swiftlint 기본에 따라가야한다 생각을 해서! 혹시 표현이 된다면 3글자 이상으로 수정할 수 있을까요? 프로젝트 전반적으로 적용되는 워닝사항이 아니라 커스텀탭바에서 편의에 따른거니깐요!
static let GroupViewController = "GroupViewController" | ||
static let TabBarViewController = "TabBarViewController" | ||
static let CustomTabBarController = "CustomTabBarController" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아 이거 변수명 소문자로 시작해야하는데,,ㅜㅜ 일단 이슈 정리해두고 나중에 바꾸져 이제부터 만들때 소문자로 하자.. 민재교수님.. 내가 처음에 잘못만들어서 그래 ㅜ
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이것도 그냥 소문자로 제가 다 바꿔서 커밋했습니다!
@@ -14,6 +14,6 @@ extension Const { | |||
static let backCardCreationCollectionViewCell = "BackCardCreationCollectionViewCell" | |||
static let cardListTableViewCell = "CardListTableViewCell" | |||
static let frontCardCell = "FrontCardCell" | |||
static let backgroundCollectionViewCell = "BackgroundCollectionViewCell" | |||
static let backgroundCollectionViewCell = "backgroundCollectionViewCell" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이것은 왜 수정하셨나요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
어랄라 이건 수정하겠습니다 ^__^
import UIKit | ||
|
||
class CustomTabBarController: UITabBarController { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 최고! UITabBarController 로 만들었다니!
🌴 PR 요약
🌱 작업한 브랜치
🌱 작업한 내용
📸 스크린샷
📮 관련 이슈