[FEAT] #36 - 커스텀 탭바 구현, 연결 #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mini-min
added
Minjae 🐻❄️
hyun99999
approved these changes
Oct 14, 2021
| @@ -3,6 +3,7 @@ disabled_rules: | |||
| - trailing_whitespace | |||
| - nesting | |||
| - function_parameter_count | |||
| - identifier_name | |||
There was a problem hiding this comment.
이건 혹시 왜 추가했나요?! 대문자 시작 워닝안하게 하려한건가?
There was a problem hiding this comment.
저게 글자수 3글자 이상이어야 하는건데, 뷰컨이나 NSLayoutConstraint 이름 vc, cr이렇게 되어있던거 워닝떠서 추가했습니다 ^__^
There was a problem hiding this comment.
음..! 최대한으로 swiftlint 기본에 따라가야한다 생각을 해서! 혹시 표현이 된다면 3글자 이상으로 수정할 수 있을까요? 프로젝트 전반적으로 적용되는 워닝사항이 아니라 커스텀탭바에서 편의에 따른거니깐요!
Comment on lines
18
to
20
| static let GroupViewController = "GroupViewController" | ||
| static let TabBarViewController = "TabBarViewController" | ||
| static let CustomTabBarController = "CustomTabBarController" |
There was a problem hiding this comment.
아 이거 변수명 소문자로 시작해야하는데,,ㅜㅜ 일단 이슈 정리해두고 나중에 바꾸져 이제부터 만들때 소문자로 하자.. 민재교수님.. 내가 처음에 잘못만들어서 그래 ㅜ
There was a problem hiding this comment.
이것도 그냥 소문자로 제가 다 바꿔서 커밋했습니다!
| @@ -14,6 +14,6 @@ extension Const { | |||
| static let backCardCreationCollectionViewCell = "BackCardCreationCollectionViewCell" | |||
| static let cardListTableViewCell = "CardListTableViewCell" | |||
| static let frontCardCell = "FrontCardCell" | |||
| static let backgroundCollectionViewCell = "BackgroundCollectionViewCell" | |||
| static let backgroundCollectionViewCell = "backgroundCollectionViewCell" | |||
| import UIKit | ||
|
|
||
| class CustomTabBarController: UITabBarController { | ||
|
|
There was a problem hiding this comment.
👍 최고! UITabBarController 로 만들었다니!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌴 PR 요약
🌱 작업한 브랜치
🌱 작업한 내용
📸 스크린샷
📮 관련 이슈