Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 명함 생성 시 내 명함 탭으로 이동 (#424) #431

Merged
merged 2 commits into from
Apr 15, 2023
Merged

feat: 명함 생성 시 내 명함 탭으로 이동 (#424) #431

merged 2 commits into from
Apr 15, 2023

Conversation

hyun99999
Copy link
Member

🌴 PR 요약

🌱 작업한 브랜치

🌱 작업한 내용

  • 명함 생성 시 내 명함 탭으로 이동 후에
  • presentingViewController가 TabBarViewController이기 때문에 다운캐스팅해서 사용.
  • presentingTabBarVC 의 선택된 뷰컨을 네비뷰컨으로 다운캐스팅하여 사용.

참고 : https://gyuios.tistory.com/123

📸 스크린샷

기능 스크린샷
명함 생성 후 이동

📮 관련 이슈

@hyun99999
feat: 명함 생성 시 내 명함 탭으로 이동 (#424)
22f6929 
- presentingVC가 TabBarViewController이기 때문에 다운캐스팅해서 사용.
@hyun99999
Merge branch 'develop' of https://github.com/TeamNADA/NADA-iOS-ForRel…
78e11b6 
…ease into feature/#424
@hyun99999 hyun99999 added Hyungyu 🐯 현규 교수님 작업 Feat 새로운 기능 구현 labels Apr 15, 2023
@hyun99999 hyun99999 requested a review from dlwns33 April 15, 2023 09:59
@hyun99999 hyun99999 self-assigned this Apr 15, 2023
dlwns33
dlwns33 approved these changes Apr 15, 2023
View reviewed changes
Copy link
Member

@dlwns33 dlwns33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다 슈웃~

...S-forRelease/Sources/ViewControllers/CardCreation/VC/CardCreationPreviewViewController.swift
Comment on lines +236 to +237
let presentingNavigationVC = presentingTabBarVC.selectedViewController as? UINavigationController else { return }

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

탭바의 선택된 뷰컨을 사용하셨군요... 음음음닁늬늬~

@hyun99999 hyun99999 merged commit df3753b into develop Apr 15, 2023
@hyun99999 hyun99999 deleted the feature/#424 branch April 15, 2023 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlwns33 dlwns33 dlwns33 approved these changes

Assignees

@hyun99999 hyun99999

Labels
Feat 새로운 기능 구현 Hyungyu 🐯 현규 교수님 작업
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: 명함 생성 시 내 명함 탭으로 이동
2 participants
@hyun99999 @dlwns33