Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 명함 그룹 조회 API 연결 #422 #432

Merged
merged 7 commits into from
Apr 15, 2023

Conversation

dlwns33
Copy link
Member

@dlwns33 dlwns33 commented Apr 15, 2023

🌴 PR 요약

🌱 작업한 브랜치

🌱 작업한 내용

  • 명함 그룹 조회 API 연결
  • 그룹에 속한 명함 조회 API 연결
  • frontCard 데이터 모델 일부 변경했습니다!

📸 스크린샷

기능 스크린샷
유효슛팅

📮 관련 이슈

@dlwns33 dlwns33 added Yijoon 🐨 이준 대치동강사 작업 Feat 새로운 기능 구현 labels Apr 15, 2023
@dlwns33 dlwns33 requested a review from hyun99999 April 15, 2023 10:00
@dlwns33 dlwns33 self-assigned this Apr 15, 2023
Copy link
Member

@hyun99999 hyun99999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

슈웃~

@@ -22,7 +22,7 @@ class CardInGroupCollectionViewCell: UICollectionViewCell {
@IBOutlet weak var instagramIcon: UIImageView!
@IBOutlet weak var urlIcon: UIImageView!
var groupId: Int?
var cardId: String?
var cardId: Int?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cardUUID 로 명함을 조회해서 그걸로 사용하면 될거 같네용

case groupID = "groupId"
case groupName
}
var cardGroupId: Int
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cardGroupID 로 사용부탁드려요 😤

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋ반영했씁니다
image

@@ -52,7 +52,8 @@ class GroupViewController: UIViewController {
// 중간 그룹 이름들 나열된 뷰
@IBAction func pushToGroupEdit(_ sender: Any) {
guard let nextVC = UIStoryboard.init(name: Const.Storyboard.Name.groupEdit, bundle: nil).instantiateViewController(withIdentifier: Const.ViewController.Identifier.groupEditViewController) as? GroupEditViewController else { return }
nextVC.serverGroups = self.serverGroups
//nextVC.serverGroups = self.serverGroups
//TODO: 고치세요
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋ

self.groupId = group.groups[self.selectedRow].groupID
self.cardListInGroupWithAPI(cardListInGroupRequest: CardListInGroupRequest(userId: UserDefaults.standard.string(forKey: Const.UserDefaultsKey.userID) ?? "", groupId: group.groups[self.selectedRow].groupID, offset: 0)) {
self.groupId = group[self.selectedRow].cardGroupId
print("✅", self.groupId)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

원만하게 잘해결하시고...

if self.frontCards?.count != 0 {
self.cardsCollectionView.scrollToItem(at: IndexPath(item: 0, section: 0), at: .top, animated: false)
}
self.isInfiniteScroll = true
}
}
print("success")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

print("groupListFetchWithAPI - success")
가 좋을 것 같네용~

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

반영했습니다!

@dlwns33 dlwns33 merged commit a39c13f into TeamNADA:develop Apr 15, 2023
@dlwns33 dlwns33 deleted the feature/#422 branch April 15, 2023 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feat 새로운 기능 구현 Yijoon 🐨 이준 대치동강사 작업
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: 명함 그룹 조회 API 연결
2 participants