Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 명함 그룹에 명함 연결 (#442, #342) #443

Merged
merged 17 commits into from
Apr 22, 2023
Merged

fix: 명함 그룹에 명함 연결 (#442, #342) #443

merged 17 commits into from
Apr 22, 2023

Conversation

hyun99999
Copy link
Member

🌴 PR 요약

🌱 작업한 브랜치

🌱 작업한 내용

📮 관련 이슈

@hyun99999
add: UserDefaulsts 추가 (TeamNADA#342)
8d8e4b4
@hyun99999
feat: 동적링크에 cardUUID 파라미터 추가 및 추출 (TeamNADA#342)
0fd2f19
@hyun99999
fix: CardAddInGropRequest 데이터 모델 수정 (TeamNADA#442)
d80638e
@hyun99999
fix: 그룹에 명함 추가 API 수정 (TeamNADA#442)
4674b7e
@hyun99999
delete: 명함 그룹 변경 API 대신 그룹에 명함 추가 API 로 사용 (TeamNADA#442)
680c2d3
@hyun99999
feat: 명함 상세 뷰로 화면전환 구현 (TeamNADA#342)
7793188
@hyun99999
Need an imageRef 버그 해결 (TeamNADA#342)
c1b3201 
- 삭제된 Card 이미지 에셋을 더이상 사용 안함.
@hyun99999
fix: ModuleFactory 수정 (TeamNADA#342)
245e019
@hyun99999
fix: 동적링크 파라미터 cardUUID 로 수정 (TeamNADA#342)
483a429
@hyun99999
refactor: keychain 삭제
1cdaabf
@hyun99999
fix: ModuleFactory 수정 (TeamNADA#342)
3a01fea 
- modalPresentationStyle 적용.
@hyun99999
add: 명함 상세 조회, 그룹에 명함 추가 API 구현 (TeamNADA#342)
271e72b
@hyun99999
refactor: 접근제어자 추가 (TeamNADA#342)
db9e986
@hyun99999
feat: 명함 상세 뷰로 화면전환 구현 (TeamNADA#342)
28f4856
@hyun99999
feat: 동적링크를 체크해서 명함 추가 (TeamNADA#342)
7e1dc34
@hyun99999
refactor: SceneDelegate 수정 (TeamNADA#342)
25ed4ec 
- 사용하지 않는 변수 와일드 카드로 변경.
@hyun99999 hyun99999 added Hyungyu 🐯 현규 교수님 작업 Fix 코드 수정 및 버그, 오류 해결 labels Apr 16, 2023
@hyun99999 hyun99999 requested a review from dlwns33 April 16, 2023 12:37
@hyun99999 hyun99999 self-assigned this Apr 16, 2023
dlwns33
dlwns33 approved these changes Apr 22, 2023
View reviewed changes
Copy link
Member

@dlwns33 dlwns33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫡🫡🫡🫡🫡🫡

@hyun99999 hyun99999 merged commit 164aa73 into TeamNADA:develop Apr 22, 2023
@hyun99999 hyun99999 deleted the feature/#342 branch April 22, 2023 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlwns33 dlwns33 dlwns33 approved these changes

Assignees

@hyun99999 hyun99999

Labels
Fix 코드 수정 및 버그, 오류 해결 Hyungyu 🐯 현규 교수님 작업
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix: 명함 그룹에 명함 연결
2 participants
@hyun99999 @dlwns33