feat: 명함 그룹 관련 API 연결 #434 #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyun99999
approved these changes
Apr 24, 2023
Comment on lines
+26
to
+28
| func makeUpdateVC() -> UpdateViewController | ||
| func makeCardDetailVC() -> CardDetailViewController | ||
| func makeGroupEditVC(groupList: [Group]) -> GroupEditViewController |
| @@ -191,7 +191,7 @@ public class GroupAPI { | |||
| else { return .pathErr } | |||
|
|
|||
| switch statusCode { | |||
| case 200: | |||
| case 200, 201: | |||
Comment on lines
+8
to
+9
| import UIKit | ||
|
|
Comment on lines
85
to
86
| groupEditTableView.register(GroupEditTableViewCell.nib(), forCellReuseIdentifier: Const.Xib.groupEditTableViewCell) | ||
| groupEditTableView.register(EmptyGroupEditTableViewCell.nib(), forCellReuseIdentifier: Const.Xib.EmptyGroupEditTableViewCell) |
There was a problem hiding this comment.
className 으로 사용해도 좋을 듯합니당 저는 일단 작업하면서 밟히는 것들부터 하나씩 적용했습니당
There was a problem hiding this comment.
아 좋습니다 좋습니다 이거 적용해놓겠습니다!
Comment on lines
+8
to
+50
| import RxSwift | ||
| import RxRelay | ||
|
|
||
| final class GroupEditViewModel: ViewModelType { | ||
|
|
||
| // MARK: - Properties | ||
|
|
||
| private let disposeBag = DisposeBag() | ||
| var groupList: [Group] = [] | ||
|
|
||
| // MARK: - Inputs | ||
|
|
||
| struct Input { | ||
| let viewWillAppearEvent: Observable<Void> | ||
| } | ||
|
|
||
| // MARK: - Outputs | ||
|
|
||
| struct Output { | ||
| var groupListRelay = PublishRelay<[Group]>() | ||
| } | ||
|
|
||
| // MARK: - Initialize | ||
|
|
||
| init(groupList: [Group]) { | ||
| self.groupList = groupList | ||
| } | ||
| } | ||
|
|
||
| extension GroupEditViewModel { | ||
| func transform(input: Input) -> Output { | ||
| let output = Output() | ||
|
|
||
| input.viewWillAppearEvent | ||
| .withUnretained(self) | ||
| .subscribe { owner, _ in | ||
| output.groupListRelay.accept(owner.groupList) | ||
| } | ||
| .disposed(by: self.disposeBag) | ||
|
|
||
| return output | ||
| } | ||
| } |
There was a problem hiding this comment.
여기서두 저번에 view model 코드리뷰와 동일하게 disposeBag 을 사용하며 뷰 모델에서 구독이 진행되서 수정되면 좋겠습니당!
There was a problem hiding this comment.
오케이 뷰컨에서 구독을 휘갈겨보겠습니다...
There was a problem hiding this comment.
선생님 뷰컨 구독 이슈 일단 냅두고 합친 다음에 이슈 다시 파서 수정하겠습니다! (제가 다른 곳에서도 뷰모델에서 구독을 갈겨놔서...)
지금 API 부터 일단 연결 다시 해보겠습니다!
There was a problem hiding this comment.
그랴요!
출시하고 좀 정리할거 정리해서 리스트업 해봅시다
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌴 PR 요약
🌱 작업한 브랜치
🌱 작업한 내용
📮 관련 이슈