feat: 덕질 명함 생성 뷰 구현 (#449) #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- digging->fan - job->company 로 변경. 서버 네이밍과 통일하였습니다.
- 인스타그램/트위터 활성, 비활성화 이미지 에셋 추가.
- 인스타그램/트위터 아이콘.
- 인스타그램, 트위터 모두 앱/웹 잘 열림.
dlwns33
approved these changes
Apr 24, 2023
Comment on lines
+95
to
+116
| @objc | ||
| private func tapSNSLabel() { | ||
| let appURL: URL? | ||
| let webURL: URL? | ||
|
|
||
| if cardData?.instagram != nil { | ||
| let instagramID = snsLabel.text ?? "" | ||
| appURL = URL(string: "instagram://user?username=\(instagramID)") | ||
| webURL = URL(string: "https://instagram.com/\(instagramID)") | ||
| } else { | ||
| let twitterID = snsLabel.text ?? "" | ||
| appURL = URL(string: "twitter://user?id=\(twitterID)") | ||
| webURL = URL(string: "https://twitter.com/\(twitterID)") | ||
| } | ||
| guard let appURL, let webURL else { return } | ||
|
|
||
| if UIApplication.shared.canOpenURL(appURL) { | ||
| UIApplication.shared.open(appURL, options: [:], completionHandler: nil) | ||
| } else { | ||
| UIApplication.shared.open(webURL, options: [:], completionHandler: nil) | ||
| } | ||
| } |
There was a problem hiding this comment.
아이고 선생님 이거 분기처리하기 빡셌을텐데 수고하셨습니다..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌴 PR 요약
🌱 작업한 브랜치
🌱 작업한 내용
feat: 덕질 명함 생성 뷰 구현 #449
fix: 이미지 업로드 속도 개선 #457
📸 스크린샷
📮 관련 이슈