Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 직장 명함 생성 뷰 구현 (#450) #459

Merged
merged 9 commits into from
Apr 26, 2023

Conversation

hyun99999
Copy link
Member

@hyun99999 hyun99999 commented Apr 24, 2023

🌴 PR 요약

🌱 작업한 브랜치

🌱 작업한 내용

  • 직장 명함 생성 뷰 구현
  • initCell 메서드 수정하여 사용하는 곳에서 편하게 사용할 수 있도록 함.
  • 명함 생성, 미리보기, 조회, 상세 조회 뷰에서 기본/덕질/직장 명함이 사용될 수 있도록 함.
  • 메일 라벨을 누르면 기본 메일앱으로 이동할 수 있도록 했습니당. 메일 양식이 맞아야 제대로 받는 사람이 추가됩니당

📮 관련 이슈

@hyun99999 hyun99999 added Hyungyu 🐯 현규 교수님 작업 Feat 새로운 기능 구현 labels Apr 24, 2023
@hyun99999 hyun99999 requested a review from dlwns33 April 24, 2023 10:29
@hyun99999 hyun99999 self-assigned this Apr 24, 2023
Copy link
Member

@dlwns33 dlwns33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

마지막 직장 까지... 고생하셨습니다 !!!

@@ -5,6 +5,7 @@
// Created by 민 on 2021/11/18.
//

import MessageUI
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오 이건 어떤 라이브러리 인가욤

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

메일 보내는것을 위한 것.. 인 것 같은데 맞을까요???

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

넵!!! 오픈소스는 아니고 메일을 위한 프레임워크입니더!

frontCardDataModel.phoneNumber ?? "",
frontCardDataModel.urls?[0] ?? "",
isShareable: isShareable)
frontCard.initCell(cardBackgroundImage, frontCardDataModel)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

모델로 받으니까 훨씬 더 깔끔해졌네요! 굿굿

@hyun99999 hyun99999 merged commit 94ba79e into TeamNADA:develop Apr 26, 2023
@hyun99999 hyun99999 deleted the feature/#450 branch April 26, 2023 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feat 새로운 기능 구현 Hyungyu 🐯 현규 교수님 작업
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: 직장 명함 생성 뷰 구현
2 participants