fix: 명함 그룹 관련 수정된 API 반영 #464 #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyun99999
approved these changes
May 2, 2023
| @@ -81,6 +96,24 @@ extension CompanyFrontCardCell { | |||
|
|
|||
| linkURLStackView.alignment = .center | |||
| } | |||
| func setConstraints() { | |||
There was a problem hiding this comment.
이제 그룹 안 명함이랑 같이 쓰고자하는거죵? 좋은 것 같습니다..!!
Comment on lines
+22
to
+45
| let cardID: Int | ||
| let cardUUID, cardType, cardName, departmentName: String | ||
| let userName, birth, mbti, instagram: String | ||
| let twitter, mailAddress: String? | ||
| let phoneNumber: String | ||
| let urls: [String] | ||
| let cardTastes: [CardTaste] | ||
| let tmi: String? | ||
| let cardImage: String | ||
| let isRepresentative: Bool | ||
|
|
||
| enum CodingKeys: String, CodingKey { | ||
| case birth | ||
| case cardID = "cardId" | ||
| case cardImage, cardName, cardType | ||
| case cardUUID = "cardUuid" | ||
| case departmentName, instagram, mailAddress, mbti, phoneNumber, tmi, twitter, urls, userName | ||
| } | ||
| } | ||
| enum CodingKeys: String, CodingKey { | ||
| case cardID = "cardId" | ||
| case cardUUID = "cardUuid" | ||
| case cardType, cardName, departmentName, userName, birth, mbti, instagram, twitter, mailAddress, phoneNumber, urls, cardTastes, tmi, cardImage, isRepresentative | ||
| } | ||
| } | ||
|
|
||
| // MARK: - CardTaste | ||
| struct CardTaste: Codable { | ||
| let cardTasteName: String | ||
| let sortOrder: Int | ||
| let isChoose: Bool | ||
| } |
There was a problem hiding this comment.
Card 그룹 안에 있는 Card 데이터 모델 그대로 사용하면될거 같아요!
CardTaste 도 CardTasteInfo 데이터 모델로 만들어뒀습니당!
There was a problem hiding this comment.
서버썜들한테 부탁드려서 최대한 같은 데이터 모델 사용하고자 했습니당!
Comment on lines
18
to
19
| func cardDeleteInGroup(cardUuid: String, cardGroupName: String, completion: @escaping (NetworkResult<Any>) -> Void) { | ||
| groupProvider.request(.cardDeleteInGroup(cardUuid: cardUuid, cardGroupName: cardGroupName)) { (result) in |
There was a problem hiding this comment.
매개변수라서 약어는 UUID 이렇게 작성해도 좋을듯합니당
Comment on lines
92
to
93
| // groupEditWithAPI(groupRequest: GroupEditRequest(groupId: nowGroup?.cardGroupId ?? 0, groupName: addGroupTextField.text ?? "")) | ||
| groupEditWithAPI(groupRequest: GroupEditRequest(groupName: nowGroup ?? "", modifyGroupName: addGroupTextField.text ?? "")) |
Comment on lines
+137
to
+139
| cardsCollectionView.register(FrontCardCell.nib(), forCellWithReuseIdentifier: FrontCardCell.className) | ||
| cardsCollectionView.register(FanFrontCardCell.nib(), forCellWithReuseIdentifier: FanFrontCardCell.className) | ||
| cardsCollectionView.register(CompanyFrontCardCell.nib(), forCellWithReuseIdentifier: CompanyFrontCardCell.className) |
| @@ -293,7 +293,7 @@ extension HomeViewController { | |||
| } | |||
| } | |||
| private func cardAddInGroupWithAPI(cardUUID: String, completion: @escaping () -> Void) { | |||
| GroupAPI.shared.cardAddInGroup(cardRequest: CardAddInGroupRequest(cardUUID: cardUUID, cardGroupID: 1)) { response in | |||
| GroupAPI.shared.cardAddInGroup(cardRequest: CardAddInGroupRequest(cardGroupName: nil, cardUUID: cardUUID)) { response in | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌴 PR 요약
🌱 작업한 브랜치
🌱 작업한 내용
명함 그룹 관련 수정된 API를 반영했습니다. 반영된 API는 다음과 같습니다.
그룹 삭제
그룹 안에 명함 삭제
명함 그룹 생성
명함 그룹에 카드 연결
명함 그룹 이름 수정
명함에 속한 카드 리스트 조회
내가 가진 명함 리스트 조회
이제 카드를 추가하고 명함 그룹을 조회할 수 있습니다.
명함 그룹 변경이 가능합니다.
이슈 List
미분류 그룹은 조회가 되지 않습니다. -> 이슈 새로파서 진행하겠습니다 서버 선생님들께도 전달했습니다.
그룹 삭제 API 가 살짝 이상해서 서버 선생님들께 전달했습니다.
그룹 안 명함 카드 레이아웃 수정중입니다. 계속 진행하겠습니다.
📮 관련 이슈