Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] #47 - 리스트뷰 세부 기능 수정과 추가 #48

Merged
merged 7 commits into from
Oct 31, 2021
Merged

[FEAT] #47 - 리스트뷰 세부 기능 수정과 추가 #48

merged 7 commits into from
Oct 31, 2021

Conversation

mini-min
Copy link
Member

🌴 PR 요약

🌱 작업한 브랜치

🌱 작업한 내용

  • 리스트뷰에서는 탭바가 보이지 않도록 수정 -> 일단 지금은 필요없긴 한데 이미 만들어 놓은거니깐..
  • 백 스와이프 제스처로 pop하는 기능 구현
  • Drag & Drop으로 cell을 정렬하는 기능 구현 -> 가장 중요한 부분!
  • 테이블뷰 셀 구분선 수정
  • 핀 고정시 해당 셀의 배경색이 같이 변하도록 수정

📸 스크린샷

기능 스크린샷
GIF Simulator Screen Recording - iPhone 12 mini - 2021-10-31 at 00 11 23

📮 관련 이슈

@mini-min mini-min added Minjae 🐻‍❄️ 민재 강남1타강사 작업 P2 / Priority Middle 우선순위 중간 Feat 새로운 기능 구현 labels Oct 30, 2021
@mini-min mini-min self-assigned this Oct 30, 2021
Copy link
Member

@hyun99999 hyun99999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

코드리뷰한 부분만 다듬어주세요!
스냅샷..까지.. 이거 꼭 공부해볼게요 민재선배

Comment on lines 27 to 38

cardListTableView.register(CardListTableViewCell.nib(), forCellReuseIdentifier: "CardListTableViewCell")

cardListTableView.delegate = self
cardListTableView.dataSource = self

self.cardListTableView.allowsSelection = false

let longPressGesture = UILongPressGestureRecognizer(target: self, action: #selector(longPressCalled(gestureRecognizer:)))
cardListTableView.addGestureRecognizer(longPressGesture)

}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

함수로 빼서 정리해주세욥!

Comment on lines 65 to 73

NotificationCenter.default.addObserver(self,
selector: #selector(nextClickRecieved),
name: NSNotification.Name("deleteTabBar"),
object: nil)
NotificationCenter.default.addObserver(self,
selector: #selector(prviousClickRecieved),
name: NSNotification.Name("expressTabBar"),
object: nil)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Const 구조체에 NSNotification.Name 도 extension 해뒀으니 추가해주세용

@mini-min mini-min merged commit 096a2e6 into TeamNADA:develop Oct 31, 2021
@mini-min mini-min deleted the feature/#47 branch October 31, 2021 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feat 새로운 기능 구현 Minjae 🐻‍❄️ 민재 강남1타강사 작업 P2 / Priority Middle 우선순위 중간
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] 리스트뷰 세부 기능 추가 및 수정
2 participants