[FEAT] #54 - 로그인, 메인, 리스트 서버통신 #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mini-min
added
Minjae 🐻❄️
hyun99999
approved these changes
Nov 12, 2021
| @@ -56,7 +104,7 @@ public class CardAPI { | |||
| } | |||
|
|
|||
| switch statusCode { | |||
| case 201: | |||
| case 200: | |||
There was a problem hiding this comment.
여기 201 을 집어넣은건요! 명함생성에서 성공이 201 번이라서 넣은건데..
생각해보니 이러면 제가 만든 getCardDetailFetch 에서도 못쓰네여.. 요건 어차피 judgeStatus 함수를 추가로 만들어야하기 때문에 추후에 또 수정하는걸로 해요!
Comment on lines
50
to
64
| func getCardListFetch(userID: String, isList: Bool, offset: Int, completion: @escaping (NetworkResult<Any>) -> Void) { | ||
| cardProvider.request(.cardListFetch(userID: userID, isList: isList, offset: offset)) { (result) in | ||
| switch result { | ||
| case .success(let response): | ||
| let statusCode = response.statusCode | ||
| let data = response.data | ||
|
|
||
| let networkResult = self.judgeGetCardDetailFetchStatus(by: statusCode, data) | ||
| completion(networkResult) | ||
|
|
||
| case .failure(let err): | ||
| print(err) | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
judgeGetCardDetailFetchStatus 에서 Card 데이터형식으로 디코딩을 할 텐데 그래서 디코딩이 안됐을텐데 혹시 서버통신해서 출력되는 것도 확인해보셨나요?!
There was a problem hiding this comment.
아 그럼 이 judgeStatus를 따로 만들어주는거겠군요
놓쳤습니다
There was a problem hiding this comment.
self.judgeGetCardDetailFetchStatus 여기에서는 data 를 card 데이터형식으로 받기 때문에 아마 민재가 사용하는 함수에서는 카드 배열이 필요했을거 같아요
그래서 judgeStatus 는 각 통신함수마다 한개씩 존재하는게 사실 맞답니다!
200번이 성공이기도 201 번이 성공이기도하고 디코딩하는 데이터 형식도 다르니깐요!
그러면 출력까지 할 수 있을까요?
There was a problem hiding this comment.
좋습니당! 쵝오! 수고했어요 민재 바쁜 와중에 ㅜㅜ 감사합니다~
Comment on lines
+115
to
+116
| case .cardDelete: | ||
| return .requestPlain |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌴 PR 요약
🌱 작업한 브랜치
🌱 작업한 내용
민재 담당 서버는 어떤거였나면?
CardAPI, CardService 작성 (User, Card)
네트워크 데이터 모델 생성
각 뷰컨에 테스트 코드 작성 -> // FIXME로 워닝 발생 부분
💡Moya 초보 개발자 민군, 얼마든지 교수님들의 날카로운 지적 환영합니다💡
📮 관련 이슈