-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] 명함생성 버튼활성화,뒷면 작성 구현(#58) #65
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고하셨습니다 교수님 센스쟁이🎃👍🏻
@@ -31,14 +31,14 @@ public class GroupAPI { | |||
} | |||
} | |||
|
|||
func deleteCardInGroupDelete(groupID: Int, cardID: String, completion: @escaping (NetworkResult<Any>) -> Void) { | |||
func cardInGroupDelete(groupID: Int, cardID: String, completion: @escaping (NetworkResult<Any>) -> Void) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
교수님! 요건 실수한 부분은 아닌데 죠기 밑에 보면 cardAddInGroup 요렇게 되어있어서 뭔가 요것두 cardDeleteInGroup 요렇게 하나로 통일하는게 나을 거 같다는 조심스러운 생각입니당!
명사 + 동사 + 어디서?(InGroup) 약간 요런식으로 가면 좋을 거 같아요!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
좋아요! 넵넵
@@ -127,14 +127,14 @@ public class GroupAPI { | |||
} | |||
} | |||
|
|||
func getCardListFetch(cardListRequest: CardListRequest, completion: @escaping (NetworkResult<Any>) -> Void) { | |||
groupProvider.request(.cardListFetch(cardListRequest: cardListRequest)) { (result) in | |||
func cardListInGroupFetch(cardListInGroupRequest: CardListInGroupRequest, completion: @escaping (NetworkResult<Any>) -> Void) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
요것두 cardListFetchInGroup 요렇게 하면 더 좋을까요..?
### Descriptions - 명사 + 동사 + InGroup 네이밍 변경
🌴 PR 요약
🌱 작업한 브랜치
🌱 작업한 내용
📮 관련 이슈