[FEAT] 명함생성 버튼활성화,뒷면 작성 구현(#58) #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlwns33
approved these changes
Nov 17, 2021
| @@ -31,14 +31,14 @@ public class GroupAPI { | |||
| } | |||
| } | |||
|
|
|||
| func deleteCardInGroupDelete(groupID: Int, cardID: String, completion: @escaping (NetworkResult<Any>) -> Void) { | |||
| func cardInGroupDelete(groupID: Int, cardID: String, completion: @escaping (NetworkResult<Any>) -> Void) { | |||
There was a problem hiding this comment.
교수님! 요건 실수한 부분은 아닌데 죠기 밑에 보면 cardAddInGroup 요렇게 되어있어서 뭔가 요것두 cardDeleteInGroup 요렇게 하나로 통일하는게 나을 거 같다는 조심스러운 생각입니당!
명사 + 동사 + 어디서?(InGroup) 약간 요런식으로 가면 좋을 거 같아요!
| @@ -127,14 +127,14 @@ public class GroupAPI { | |||
| } | |||
| } | |||
|
|
|||
| func getCardListFetch(cardListRequest: CardListRequest, completion: @escaping (NetworkResult<Any>) -> Void) { | |||
| groupProvider.request(.cardListFetch(cardListRequest: cardListRequest)) { (result) in | |||
| func cardListInGroupFetch(cardListInGroupRequest: CardListInGroupRequest, completion: @escaping (NetworkResult<Any>) -> Void) { | |||
There was a problem hiding this comment.
요것두 cardListFetchInGroup 요렇게 하면 더 좋을까요..?
### Descriptions - 명사 + 동사 + InGroup 네이밍 변경
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌴 PR 요약
🌱 작업한 브랜치
🌱 작업한 내용
📮 관련 이슈