Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] #73 - 명함생성 미리보기 뷰 만들기 #77

Merged
merged 1 commit into from
Nov 25, 2021

Conversation

hyun99999
Copy link
Member

🌴 PR 요약

🌱 작업한 브랜치

🌱 작업한 내용

  • 명함생성 미리보기 뷰 구현
  • FrontCardCell 뷰 구현
  • 제스쳐는 등록 아직 안함

📸 스크린샷

기능 스크린샷
미리보기 뷰
frontCardCell

📮 관련 이슈

@hyun99999 hyun99999 added Hyungyu 🐯 현규 교수님 작업 P1 / Priority High 우선순위 높음 Feat 새로운 기능 구현 labels Nov 25, 2021
@hyun99999 hyun99999 self-assigned this Nov 25, 2021
Copy link
Member

@dlwns33 dlwns33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니당!!!

window?.rootViewController = UIStoryboard(name: Const.Storyboard.Name.tabBar, bundle: nil).instantiateViewController(withIdentifier: Const.ViewController.Identifier.tabBarViewController)
// window?.rootViewController = TabBarViewController()
window?.rootViewController = UIStoryboard(name: Const.Storyboard.Name.cardCreationPreview, bundle: nil).instantiateViewController(withIdentifier: Const.ViewController.Identifier.cardCreationPreviewViewController)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

교수님 이거 테스트 하시느라 바꿔놓으신건가용

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아차차 얍얍

override func awakeFromNib() {
super.awakeFromNib()
setUI()
}

static func nib() -> UINib {
return UINib(nibName: "FrontCardCell", bundle: nil)
return UINib(nibName: "FrontCardCell", bundle: Bundle(for: FrontCardCell.self))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 부분이 그 오류를 없앤 부분인가요 교수님??🥺

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이렇게 하면 없어진다는데 안되서 일단 다른 쪽도 문제가 있나 해보고 이슈파고 해결하려구용

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

저는 얼렁뚤땅 없어졌던 에러를 이렇게....또 하나 배워갑니다 교수님👍🏻

@hyun99999 hyun99999 merged commit 8871620 into TeamNADA:develop Nov 25, 2021
@hyun99999 hyun99999 deleted the feature/#73 branch November 25, 2021 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feat 새로운 기능 구현 Hyungyu 🐯 현규 교수님 작업 P1 / Priority High 우선순위 높음
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] 명함생성 미리보기 뷰 만들기
3 participants