-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ADD] #80 - 다크모드 아이콘 에셋 추가, #78 - 명함생성 뷰 수정 #81
Conversation
### Descriptions - 뷰가 변경되면서 서버관련 모델, 서비스 변경 > CardCreationRequest 데이터모델 수정 > CardService 수정 - 수정된 뷰 반영 ### Todo - 라이트, 다크 모드 대응 ### Fix - @IBDesignables err 이슈파서 하기
### Descriptions - 다크모드 아이콘 에셋 추가
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
감사합니당~~~!!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
생성뷰는 코드가 너무 길어서 일일이 폰트, 색 바꾸는거 많이 고생하셨겠네욥 ㅜㅜㅜ
최고입니다 ^__^
import UIKit | ||
|
||
extension UITextField { | ||
func addLeftPadding() { | ||
let paddingView = UIView(frame: CGRect(x: 0, y: 0, width: 12, height: self.frame.height)) | ||
self.leftView = paddingView | ||
self.leftViewMode = ViewMode.always | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
헐 교수님도 이걸 추가해주셨군요!
저도 바텀시트에서 쓰려고 left패딩이랑 right패딩까지 추가해서 올려뒀었는데, 소름돋는군요
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
제걸 지우겠습니당
@@ -108,7 +106,7 @@ extension BackCardCreationCollectionViewCell { | |||
_ = textFieldList.map { $0.delegate = self } | |||
} | |||
static func nib() -> UINib { | |||
return UINib(nibName: "BackCardCreationCollectionViewCell", bundle: nil) | |||
return UINib(nibName: Const.Xib.backCardCreationCollectionViewCell, bundle: Bundle(for: BackCardCreationCollectionViewCell.self)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
scrollView.backgroundColor = .primary | ||
bgView.backgroundColor = .primary | ||
backgroundSettingCollectionView.backgroundColor = .primary |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
control + i....(?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
머쓱 ㅋㅋㅋㅋ
backgroundAttributeString.addAttribute(.foregroundColor, value: UIColor.mainColorNadaMain, range: NSRange(location: 0, length: 1)) | ||
backgroundAttributeString.addAttribute(.foregroundColor, value: UIColor.secondary, range: NSRange(location: 1, length: backgroundAttributeString.length - 1)) | ||
setBackgroundTextLabel.attributedText = backgroundAttributeString | ||
setBackgroundTextLabel.font = .textBold01 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
control + i...2....(?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
머쓱... 2
cardTitleTextField.attributedPlaceholder = NSAttributedString(string: "명함 이름 (15자)", attributes: [ | ||
NSAttributedString.Key.foregroundColor: UIColor.quaternary | ||
]) | ||
userNameTextField.attributedPlaceholder = NSAttributedString(string: "본인 이름 (15자)", attributes: [ | ||
NSAttributedString.Key.foregroundColor: UIColor.quaternary | ||
]) | ||
birthTextField.attributedPlaceholder = NSAttributedString(string: "생년월일", attributes: [ | ||
NSAttributedString.Key.foregroundColor: UIColor.quaternary | ||
]) | ||
mbtiTextField.attributedPlaceholder = NSAttributedString(string: "MBTI", attributes: [ | ||
NSAttributedString.Key.foregroundColor: UIColor.quaternary | ||
]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
한줄로 쭉보다 훨씬 깔끔하네요👍🏻
$0.borderStyle = .none | ||
$0.addLeftPadding() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이 부분은 extension 제껄로 합치면, 파라미터로 간격만 설정해주면 좋을것 같습니다 ^__^
$0.borderStyle = .none | ||
$0.addLeftPadding() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
여기두요!
bgView.cornerRadius = 10 | ||
|
||
// flavorLabel.font = .hint | ||
// flavorLabel.textColor = .hintGray1 | ||
flavorLabel.lineBreakMode = .byTruncatingTail |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
얘는 지워도 상관없는건가욥!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
걍 해보려다가 저기 부분은 진짜 도저히 안되겠어서 걍 뒀습니다 ㅋㅋㅋ 다크모드 대응할 때 고칠게요!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mini-min
아 요거 수정됐는데 코리당시에는 있었던건가요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아뇨아뇨! 저 lineBreak를 지우시고 따로 추가 안했길래 지워도 되는건지 물어본겁니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아아아 그 얘기구나 넵 불필요하게 생각들어서 지웠습니당!
@@ -70,8 +70,9 @@ class FrontViewController: UIViewController { | |||
// 명함 생성 뷰로 화면 전환 | |||
@IBAction func presentToCardCreationView(_ sender: Any) { | |||
let nextVC = UIStoryboard(name: Const.Storyboard.Name.cardCreation, bundle: nil).instantiateViewController(withIdentifier: Const.ViewController.Identifier.cardCreationViewController) | |||
nextVC.modalPresentationStyle = .overFullScreen | |||
self.present(nextVC, animated: true, completion: nil) | |||
let navigationController = UINavigationController(rootViewController: nextVC) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
네비게이션으로 감싸주셨군요...!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
넵! 꼼꼼한 리뷰.. 최고
🌴 PR 요약
🌱 작업한 브랜치
🌱 작업한 내용
#80
#78
Todo
Fix
📮 관련 이슈