-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] #46 - 명함 그룹화면 구현 #84
Merged
Merged
Changes from 13 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
8598c5c
[FEAT] #46 명함 그룹 뷰 네비게이션 바 추가
dlwns33 5dd8ac9
[FEAT] #46 명함 그룹 레이아웃 잡기
dlwns33 bee89df
[FEAT] #46 그룹 collectionview cell 추가
dlwns33 f3865d9
[FEAT] #46 collectionview 큰 레이아웃 완료
dlwns33 f9b4f5d
[FEAT] #46 그룹명 다이나믹 셀
dlwns33 2c2ee45
[REFACTOR] #46 collectionview switch 문 사용
dlwns33 078bdf6
Merge branch 'develop' into feature/#46
dlwns33 539ac3d
[FEAT] #46 그룹 편집 뷰 이어지게
dlwns33 af68891
[FEAT] #46 명함 그룹 뷰 셀 따로 만들기
dlwns33 a4f32d6
[FEAT] #46 명함 그룹 뷰 셀 IBoutlet 추가
dlwns33 137a66f
[FEAT] #46 아이디로 추가 bottomSheet 연결
dlwns33 7f0091c
[FEAT] #46 ID검색 뒤 명함 bottomSheet 연결
dlwns33 f0750a2
[FEAT] #46 QR스캔 화면 생성
dlwns33 15d0f8e
[FEAT] #46 const 에 bottomsheet 추가
dlwns33 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,6 +17,7 @@ extension Const { | |
static let frontViewController = "FrontViewController" | ||
static let groupViewController = "GroupViewController" | ||
static let groupEditViewController = "GroupEditViewController" | ||
static let qrScanViewController = "QRScanViewController" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 바텀시트도 Constants에 같이 추가해두면 좋을 것 같습니다 선배님! There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 오우 굿포인트 지금 바로 추가할게여!!! |
||
static let tabBarViewController = "TabBarViewController" | ||
static let commonBottomSheetViewController = "CommonBottomSheetViewController" | ||
static let cardCreationPreviewViewController = "CardCreationPreviewViewController" | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
어라라라ㅏ 혹쉬 이게 빠져있는거는 위치가 변경되서 그런걸까요...?
아니면 pull을 안받아서일까요..?
이준교수님 xcode에서는 잘 되는건가욥..?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
안그래두.. 나도 이게 뭐지 싶었는데 또 깃허브랑 엑스코드에서는 파일이 잘 있더라구..?
풀은 분명히 중간에 최신걸로 받았는데... 이상허다 싶었어...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UITextField+Extension 파일을 민재랑 내가 동시에 만들어서 내가 삭제해줘서 그런거 같네요1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아하... 글면 괜찮을거 같슴다..!