[FIX] #87 - 명함 그룹 화면 수정 #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mini-min
approved these changes
Nov 29, 2021
| @@ -85,7 +85,7 @@ | |||
| <constraints> | |||
| <constraint firstAttribute="height" constant="32" id="4E1-ms-weE"/> | |||
| </constraints> | |||
| <collectionViewFlowLayout key="collectionViewLayout" scrollDirection="horizontal" automaticEstimatedItemSize="YES" minimumLineSpacing="10" minimumInteritemSpacing="10" id="gMe-6U-LJh"> | |||
| <collectionViewFlowLayout key="collectionViewLayout" scrollDirection="horizontal" minimumLineSpacing="10" minimumInteritemSpacing="10" id="gMe-6U-LJh"> | |||
There was a problem hiding this comment.
헐 background 색상 이 이슈에 같이 수정해야겠네요!!! 감사함둥 ㅠㅠ
There was a problem hiding this comment.
고생하셨습니다 교수님!! 이거는 조금 다른 얘기인데 이미 아실수도 있지만, 그룹화면에 컬렉션 뷰 2개 모두 background 색상이 아직 설정이 안되어 있는 것 같더라구요!! 이것두 나중에 이슈파서 진행하시거나 이 이슈에 한번에 수정해주시면 감사하겠습니다 ^__^
설정 완료하고 폴더아이콘도 다크모드 추가했슴당 !!!!
Comment on lines
+302
to
+307
| switch collectionView { | ||
| case groupCollectionView: | ||
| return .init(top: 0, left: 0, bottom: 0, right: 10) | ||
| default: | ||
| return .zero | ||
| } |
There was a problem hiding this comment.
캬..! 좋습니다!
더 디테일한건 QA 때 뵙도록 하져
hyun99999
approved these changes
Nov 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌴 PR 요약
🌱 작업한 브랜치
🌱 작업한 내용
📸 스크린샷
📮 관련 이슈