-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] #87 - 명함 그룹 화면 수정 #93
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다 교수님!!
이거는 조금 다른 얘기인데 이미 아실수도 있지만,
그룹화면에 컬렉션 뷰 2개 모두 background 색상이 아직 설정이 안되어 있는 것 같더라구요!!
이것두 나중에 이슈파서 진행하시거나 이 이슈에 한번에 수정해주시면 감사하겠습니다 ^__^
@@ -85,7 +85,7 @@ | |||
<constraints> | |||
<constraint firstAttribute="height" constant="32" id="4E1-ms-weE"/> | |||
</constraints> | |||
<collectionViewFlowLayout key="collectionViewLayout" scrollDirection="horizontal" automaticEstimatedItemSize="YES" minimumLineSpacing="10" minimumInteritemSpacing="10" id="gMe-6U-LJh"> | |||
<collectionViewFlowLayout key="collectionViewLayout" scrollDirection="horizontal" minimumLineSpacing="10" minimumInteritemSpacing="10" id="gMe-6U-LJh"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
크으 도-약🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
헐 background 색상 이 이슈에 같이 수정해야겠네요!!! 감사함둥 ㅠㅠ
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다 교수님!! 이거는 조금 다른 얘기인데 이미 아실수도 있지만, 그룹화면에 컬렉션 뷰 2개 모두 background 색상이 아직 설정이 안되어 있는 것 같더라구요!! 이것두 나중에 이슈파서 진행하시거나 이 이슈에 한번에 수정해주시면 감사하겠습니다 ^__^
설정 완료하고 폴더아이콘도 다크모드 추가했슴당 !!!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
좋씀다!
switch collectionView { | ||
case groupCollectionView: | ||
return .init(top: 0, left: 0, bottom: 0, right: 10) | ||
default: | ||
return .zero | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
역시 해결할줄 알았습니다 교수님
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
캬..! 좋습니다!
더 디테일한건 QA 때 뵙도록 하져
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
line ... inter.. ㅜ... 된다면 오케이입니다!!
🌴 PR 요약
🌱 작업한 브랜치
🌱 작업한 내용
📸 스크린샷
📮 관련 이슈