Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] #91 - 다크, 라이트 모드는 일단 시스템 따라가기로 #98

Merged
merged 5 commits into from
Nov 30, 2021
Merged

[FEAT] #91 - 다크, 라이트 모드는 일단 시스템 따라가기로 #98

merged 5 commits into from
Nov 30, 2021

Conversation

mini-min
Copy link
Member

@mini-min mini-min commented Nov 30, 2021 •
edited
Loading

🌴 PR 요약

🌱 작업한 브랜치

🌱 작업한 내용

  • 일단 작업했던 내용은 주석으로 TODO 처리 해두었습니다.
  • 라이트, 다크 모드는 일단 시스템을 따라가도록 바꿔둔 상태입니다.
  • 카카오톡 로직 먼저짜러 출발~!

📮 관련 이슈

@mini-min mini-min added Minjae 🐻‍❄️ 민재 강남1타강사 작업 Feat 새로운 기능 구현 labels Nov 30, 2021
@mini-min mini-min self-assigned this Nov 30, 2021
hyun99999
hyun99999 approved these changes Nov 30, 2021
View reviewed changes
Copy link
Member

@hyun99999 hyun99999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

시스템 따라가기로 땅땅땅! 고생해써.. 푹 쉬고 조심히 출장가유

NADA-iOS-forRelease/Sources/ViewControllers/More/MoreViewController.swift Outdated
@@ -6,6 +6,7 @@
//

import UIKit
import SkeletonView
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

선배.. 혹시 스켈레톤 쓰시나여..?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

에.......이게 왜 들어가찌...긁적

dlwns33
dlwns33 approved these changes Nov 30, 2021
View reviewed changes
Copy link
Member

@dlwns33 dlwns33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

민재 수고했어요!~ 출장 조심히 다녀와~

@mini-min mini-min merged commit fafb43f into TeamNADA:develop Nov 30, 2021
@mini-min mini-min deleted the feature/#91 branch November 30, 2021 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlwns33 dlwns33 dlwns33 approved these changes

@hyun99999 hyun99999 hyun99999 approved these changes

Assignees

@mini-min mini-min

Labels
Feat 새로운 기능 구현 Minjae 🐻‍❄️ 민재 강남1타강사 작업
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEAT] 스위치 값에 따른 다크모드 변경 기능 추가
3 participants
@mini-min @dlwns33 @hyun99999