-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 0.21.9 #6841
Comments
@Movisivi No, this is a test apk. It's not a mainstream release. It will NOT install over your main app rather as a separate app. It's released to make sure that users don't encounter bugs. A stable apk will be released later once the bugs (if bugs do exist) are fixed. |
The color depends on the currently chosen service, not on the video currently being played. Then again, maybe you actually had SoundCloud selected. Let me check. Btw, when you send screenshots, could you please make them properly sized? Use |
@SameenAhnaf does #6847 solve it? |
Error to download a video:
|
The colors are not changed according to selected service for these sections :
Is this intended behaviour? |
@skyGtm Technically, these three sections behave the same for all services at least for now. So, I guess, changing these sections' colours might be unnecessary or even misleading as the differenciation is of no use. |
@flopezre could you provide more info? Android version, the video you were downloading, resolution, audio/video, SAF or non-SAF, ... |
Has that something to do with youtubei @TiA4f8R |
Android version: 11 |
@flopezre I could download it just fine. But it's 2.19GB, so I guess that's causing the issue. Are you sure you have enough free space on disk? And are you sure your filesystem supports files that big? Anyway, I don't think that crash is related to the new release, as we didn't change anything regarding the downloader. @kapodamy could you check that stacktrace? |
@Stypox ok, i try to reinstall. Thanks Update: now works perfect 👌👌 |
Age-restricted videos fixed? |
@Stypox The issue is present since a while ago, (I can reproduce it on the current version) and is an extractor issue: see https://github.com/TeamNewPipe/NewPipeExtractor/blob/dev/extractor/src/main/java/org/schabi/newpipe/extractor/services/youtube/extractors/YoutubeStreamInfoItemExtractor.java#L238-L240 Here is the commit which added this code: TeamNewPipe/NewPipeExtractor@b88188d#diff-2d29793b2428b5ed716b13435abfad6b7af77d412b65dfcb513998610f69e444 This commit may be however not responsible of the current issue, lower thumbnails may have been added by YouTube after the code was implemented in the extractor. |
@bookkojot Some, not all. |
This comment has been minimized.
This comment has been minimized.
I'm using the pre-release app for 0.21.9 (with SAF enabled) and I experience #6667, which was supposedly fixed and released in 0.21.7... To start the download I have to open the app, go in the download queue and start the download manually. demonstration in video2021-08-09-212919245.mp4NOTE: For some reason (but not often, doesn't always reproduce) the download isn't always queued (but that might be a separate bug). |
@bew Mmmh no, #6667 is unrelated. At least your app doesn't crash. I don't know if that happened in previous versions, too, or if this is a regression. Anyway, I took a look at the code and found two things that could queue the download without starting it:
Anyway, could you send a screenshot of your download settings screen? thank you ;-) |
Maybe we should have a neutral colour for non-service-related sections? |
@opusforlife2 Shouldn't Newpipe app icon itself should be other than red in that case? After all, app icon is one of the core neutral parts. |
@SameenAhnaf That then affects the familiarity/discoverability factor, which needs a far more detailed discussion as it may hurt the app instead of helping. |
@opusforlife2 Personally, I think that finding a neutral color is too general at this moment. The related PRs #6771 and #6456 actually were supposed to apply theme to each service. Even if we don't apply neutral color on app icon right now, surely a new issue will be generated. So, it's best to have a discussion on this later. |
NewPipe_v0.21.9_RC2.zip
|
This comment has been minimized.
This comment has been minimized.
get error when try , import database Exception
Crash log
|
@Disqu3-mirOir-qt Your OS does not seem to support SAF, even though it should since it's Android 8. Just disable it in "Settings -> Download -> Use Storage Access Framework". This issue is anyway unrelated to this release. @nadiration next release, this release is already on its way |
This is a problem that I found in this update.
|
@Thewisem This is an old issue and not exclusive to this release. See: #6472. |
Oops Sorry then |
I can't reproduce |
@Stypox The bug seems to persist for other media player apps on my device. So, pardon me if I did something wrong. However, 'Mark as Watched' does nothing if watch history is disabled. Shouldn't it be hidden if history is disabled? Or, maybe, support for temporary watch history (until closing the app) could be added. |
Will be fixed by #6956 |
hiii,
how?? 🤔 it showed no such options in that comments 3-dot menu. had lost this comment, refound by: 🔍 repo:teamnewpipe/newpipe in:comments img src |
APK for testing
From GitHub Actions: NewPipe_v0.21.9_RC2.zip
Corresponding pull request: #6840
TODO
App changelog
New
Improved
Fixed
Development
The text was updated successfully, but these errors were encountered: